Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Matching] Allow 'ignore' as inputtype #766

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dbajpeyi
Copy link
Collaborator

@dbajpeyi dbajpeyi commented Mar 4, 2025

Reviewer: @alistairjcbrown
Asana: https://app.asana.com/0/1199539352118559/1209563380559788

Description

We want to ability to ignore inputs that we intentionally don't want to be inferred. Adding a new intentional type called ignore that gets checked in getInputType, that will allow us to hardcode this. E.g on email protection signup, we don't want the email field to popup another email protection promo:
image

@dbajpeyi dbajpeyi changed the title feat: allow ignoring input types [Matching] Allow 'ignore' as inputtype Mar 4, 2025
@dbajpeyi dbajpeyi marked this pull request as ready for review March 4, 2025 14:05
@dbajpeyi dbajpeyi requested a review from alistairjcbrown March 4, 2025 14:14
@dbajpeyi dbajpeyi force-pushed the dbajpeyi/feat/add-ignore-inputtype branch from e2d443c to e2fb010 Compare March 4, 2025 14:47
@dbajpeyi dbajpeyi force-pushed the dbajpeyi/feat/add-ignore-inputtype branch from e2fb010 to 07b2984 Compare March 4, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant