Remove obsolete maestro test and add one for the dismissal of Dax fire dialog #5898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es not exist anymore.
cmonfortep
approved these changes
Apr 11, 2025
nalcalag
reviewed
Apr 11, 2025
Good catch. There are many tests for dismissing Dax dialogs in |
anikiki
changed the title
CDRussell
reviewed
Apr 11, 2025
Comment on lines
24
to
28
| - assertVisible: | ||
| text: ".*Remember: every time you browse with me a creepy ad loses its wings.*" | ||
| id: daxDialogDismissButton | ||
| - tapOn: | ||
| id: "com.duckduckgo.mobile.android:id/fireIconImageView" | ||
| - tapOn: "Clear All Tabs And Data" | ||
| - assertNotVisible: "You've got this!.*" No newline at end of file | ||
| id: daxDialogDismissButton |
There was a problem hiding this comment.
nit: i believe it’s redundant to assertVisible and then tapOn the same element since the tapOn will fail if it can’t be found anyway. so it’s slightly faster to omit the first check.
I know we’ve got this pairing throughout the tests but i’ve been removing the first step where i’ve been in making changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
fire_dialog_during_onboarding.yamltest as the skip button does not exist anymore.Added
dimiss_fire_during_onboarding.yamlto specifically test the dismissal of the Dax fire dialog.Task/Issue URL: https://app.asana.com/1/137249556945/project/1200905986587319/task/1209951369112706?focus=true
Description
Steps to test this PR
maestro test dimiss_fire_during_onboarding.yaml
NO UI changes