Bring New Tab Pixel back #5591
Open
Bring New Tab Pixel back #5591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malmstein
force-pushed
the
feature/david/02-04-bring_new_tab_pixel_back
branch
from
7179691 to
7c63556
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1157893581871903/1209314661682838
Description
We wrongly removed the New Tab pixel in #5396
This PR brings them back, adding missing tests and splitting this from origin, as it was intended to do in the first place.
Steps to test this PR
From SERP
m_new_tab_open_from_serpis firedFrom any site
m_new_tab_open_from_siteis fired