Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close custom tab on leave site #5587

Conversation

CrisBarreiro
Copy link
Contributor

@CrisBarreiro CrisBarreiro commented Feb 3, 2025

Task/Issue URL: https://app.asana.com/0/0/1209302824452673/f

Description

Steps to test this PR

Feature 1

Feature 1

Feature 1

Feature 1

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@CrisBarreiro CrisBarreiro force-pushed the feature/cris/malicious-site-protection/close-custom-tab-on-leave-site branch from 48999fb to f9a16be Compare February 3, 2025 18:31
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/malicious-site-protection/close-custom-tab-on-leave-site branch from f9a16be to b333c4e Compare February 3, 2025 22:09
Copy link
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @CrisBarreiro. Works as expected!

Copy link
Contributor

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrisBarreiro CrisBarreiro merged commit 1a32a0d into develop Feb 4, 2025
8 checks passed
@CrisBarreiro CrisBarreiro deleted the feature/cris/malicious-site-protection/close-custom-tab-on-leave-site branch February 4, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants