Scope exemptions to tab #5585
Merged
Scope exemptions to tab #5585
+24
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 3, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CrisBarreiro
force-pushed
the
feature/cris/malicious-site-protection/scope-exemptions-to-tab
branch
from
1e7059b to
99fddc2
Compare
cmonfortep
approved these changes
Feb 4, 2025
| @@ -223,6 +225,10 @@ class WebViewRequestInterceptor( | |||
| url?.let { webViewClientListener?.onReceivedMaliciousSiteWarning(it, feed, exempted) } | |||
| } | |||
|
|
|||
| override fun addExemptedMaliciousSite(url: Uri, feed: Feed) { | |||
| maliciousSiteBlockerWebViewIntegration.onSiteExempted(url, feed) | |||
There was a problem hiding this comment.
Posted on another PR (so depends on that answer), I assume we need to pass Feed to exempted logic.
There was a problem hiding this comment.
Yes, so that when a URL is identified as exempted, we can setup the privacy dashboard accordingly
CrisBarreiro
merged commit 47c4dfc
into
feature/cris/malicious-site-protection/add-feed-to-return-type
6 of 7 checks passed
CrisBarreiro
deleted the
feature/cris/malicious-site-protection/scope-exemptions-to-tab
branch
This was referenced Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1205008441501016/1209289574297312
Description
Scope exemptions per tab, not per app
Steps to test this PR
Feature 1