Show prompt if all in-context dialogs have been shown #5580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmac012
approved these changes
Feb 3, 2025
| @@ -334,7 +334,7 @@ class CtaViewModel @Inject constructor( | |||
| return null | |||
| } | |||
|
|
|||
| if (!canShowOnboardingDaxDialogCta()) { | |||
| if (areInContextDaxDialogsCompleted()) { | |||
There was a problem hiding this comment.
I'd remove canShowOnboardingDaxDialogCta() method since it is no longer used anywhere.
CrisBarreiro
force-pushed
the
feature/cris/show-broken-site-prompt-after-in-context-dialogs
branch
from
002552c to
c61f047
Compare
CrisBarreiro
deleted the
feature/cris/show-broken-site-prompt-after-in-context-dialogs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1205008441501016/1209303563866691
Description
Do not wait for the full onboarding to be completed to be able to show the broken site prompt, just wait for all in-context dialogs to show
Steps to test this PR
Feature 1
UI changes