-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user setting to enable/disable malicious site protection #5579
Merged
laghee
merged 10 commits into
develop
from
feature/cris/malicious-site-protection/user-setting
Feb 5, 2025
Merged
Add user setting to enable/disable malicious site protection #5579
laghee
merged 10 commits into
develop
from
feature/cris/malicious-site-protection/user-setting
Feb 5, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrisBarreiro
reviewed
Feb 4, 2025
app/src/main/java/com/duckduckgo/app/browser/webview/MaliciousSiteBlockerWebViewIntegration.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/generalsettings/GeneralSettingsActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/generalsettings/GeneralSettingsActivity.kt
Outdated
Show resolved
Hide resolved
CrisBarreiro
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of small comments but looks good and works as expected, great job!
laghee
deleted the
feature/cris/malicious-site-protection/user-setting
branch
February 5, 2025 02:01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1207943168535187/f
Description
Add general setting to allow user to toggle malicious site protection on/off
Steps to test this PR
Feature 1
UI changes