Fix Dax dialog scrolling for small devices #5573
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
nalcalag
force-pushed
the
feature/noelia/release_highlight_onboarding_to_all_users
branch
from
5deffb0 to
a844aaf
Compare
nalcalag
force-pushed
the
feature/noelia/release_highlight_onboarding_to_all_users
branch
from
a844aaf to
03de1c6
Compare
nalcalag
force-pushed
the
feature/noelia/release_highlight_onboarding_to_all_users
branch
from
03de1c6 to
9625e45
Compare
nalcalag
force-pushed
the
feature/noelia/fix_onboarding_scroll_small_devices
branch
from
abafa75 to
bd455d5
Compare
Task/Issue URL: https://app.asana.com/0/1201807753394693/1209307760721992 ### Description Remove highlight on fire button after Fire dialog is dismissed ### Steps to test this PR - [ ] Fresh install - [ ] Go to browser - [ ] Go to a trackers website (e.g. bbc.co.uk) - [ ] Tap on Got it! button - [ ] Check Fire button is highlighted - [ ] Tap on Skip - [ ] Check Fire button highlight is removed ### No UI changes
nalcalag
force-pushed
the
feature/noelia/fix_onboarding_scroll_small_devices
branch
from
bd455d5 to
78cafaa
Compare
|
@nalcalag The privacy protections dialog works as expected, nice work! After continuing with the onboarding, however, I noticed that these screens are still not scrollable (see the screenshots below). A similar fix could be applied to them as well, WDYT? 
|
@0nko thanks for the review! I can't see the images you attached, but I assume you're referring to the Dax dialogs on the new tab page once the browser is visible. I agree they should be scrollable, but since they don't block browser usage and fixing this would require handling the keyboard responsiveness within the browser content, it's out of scope for this task. Hope that makes sense! |
Task/Issue URL: https://app.asana.com/0/488551667048375/1208088786036608
Description
Fix Dax dialog being cut off on the bottom of the pre-onbaording screen in small devices
Steps to test this PR
UI changes