Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try catch queryIntentActivities else return emptylist #5572

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

aitorvs
Copy link
Collaborator

@aitorvs aitorvs commented Jan 31, 2025

Task/Issue URL: https://app.asana.com/0/1202552961248957/1206857429109107/f

Description

try-catch the call to queryIntentActivities and return empty list instead

Steps to test this PR

NA, just code review

Copy link
Collaborator Author

aitorvs commented Jan 31, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@anikiki anikiki self-assigned this Jan 31, 2025
Copy link
Contributor

@anikiki anikiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@@ -131,7 +131,11 @@ class SpecialUrlDetectorImpl(

@Throws(URISyntaxException::class)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove annotation

@aitorvs aitorvs merged commit 25f37b0 into develop Jan 31, 2025
9 checks passed
@aitorvs aitorvs deleted the fix/aitor/try-catch-queryIntentActivities branch January 31, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants