Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform deeper domain comparison for saving/updating autofill passwords #5570

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Perform deeper domain comparison for saving/updating autofill passwords #5570

wants to merge 1 commit into from

Conversation

CDRussell
Copy link
Member

@CDRussell CDRussell commented Jan 31, 2025 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1203822806345703/1209273715877308/f

Description

  • Right now, we will offer to autofill into a page which is considered an E-TLD+1 match
  • But when it comes to offering to save a password, or update an existing one, we don’t consider E-TLD+1 which leads to more scenarios with duplicate passwords.

Steps to test this PR

Detailed in Test scenarios

@CDRussell Graphite App
Copy link
Member Author

CDRussell commented Jan 31, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@CDRussell CDRussell assigned CDRussell and cmonfortep and unassigned CDRussell Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cmonfortep cmonfortep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CDRussell @cmonfortep