-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release highlights onboarding to all users #5558
Merged
nalcalag
merged 6 commits into
develop
from
feature/noelia/release_highlight_onboarding_to_all_users
Feb 4, 2025
Merged
Release highlights onboarding to all users #5558
nalcalag
merged 6 commits into
develop
from
feature/noelia/release_highlight_onboarding_to_all_users
Feb 4, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
nalcalag
force-pushed
the
feature/noelia/release_highlight_onboarding_to_all_users
branch
from
January 31, 2025 15:32
fd83923
to
5deffb0
Compare
4 tasks
anikiki
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works as expected! 🎉
nalcalag
force-pushed
the
feature/noelia/release_highlight_onboarding_to_all_users
branch
from
February 3, 2025 13:22
5deffb0
to
a844aaf
Compare
nalcalag
force-pushed
the
feature/noelia/release_highlight_onboarding_to_all_users
branch
from
February 3, 2025 13:22
a844aaf
to
03de1c6
Compare
nalcalag
force-pushed
the
feature/noelia/release_highlight_onboarding_to_all_users
branch
from
February 3, 2025 15:14
03de1c6
to
9625e45
Compare
Task/Issue URL: https://app.asana.com/0/1201807753394693/1209307760721992 ### Description Remove highlight on fire button after Fire dialog is dismissed ### Steps to test this PR - [ ] Fresh install - [ ] Go to browser - [ ] Go to a trackers website (e.g. bbc.co.uk) - [ ] Tap on Got it! button - [ ] Check Fire button is highlighted - [ ] Tap on Skip - [ ] Check Fire button highlight is removed ### No UI changes
nalcalag
deleted the
feature/noelia/release_highlight_onboarding_to_all_users
branch
February 4, 2025 01:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201807753394693/1208993305552531/f
Description
Release changes to the onboarding flow tested in Highlights Onboarding experiment
Steps to test this PR
Pre onboarding
m_preonboarding_address_bar_position_dialog_shown_unique
is firedm_preonboarding_bottom_address_bar_selected_unique
is fired...
Try a search Dax dialog
Surprise me!
optionbaby ducklings
search (images section)...
SERP Dax dialog
m_odc_s
is fired with parametercta = s
...
Site suggestions Dax dialog
m_odc_s
is fired with parametercta = visit_site
...
Trackers Blocked Dax dialog
m_odc_s
is fired with parametercta = t
Got it!
button...
Fire Button Dax dialog
m_odc_s
is fired with parametercta = fd
...
End onboarding dialog
Fire Dax dialog 'Skip' button
m_onboarding_dax_cta_cancel
is fired with parametercta = fd
m_odc_s
is fired with parametercta = end
Fire Dax dialog 'Try it' button
m_odc_ok
is fired with parametercta = fd
m_odc_s
is fired with parametercta = end
No Trackers Dax dialog
wikipedia.org
m_odc_s
is fired with parametercta = nt
...
Trackers Network Dax dialog
facebook.com
m_odc_s
is fired with parametercta = n
...
Some UI changes