Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release highlights onboarding to all users #5558

Merged

Conversation

nalcalag
Copy link
Contributor

@nalcalag nalcalag commented Jan 29, 2025

Task/Issue URL: https://app.asana.com/0/1201807753394693/1208993305552531/f

Description

Release changes to the onboarding flow tested in Highlights Onboarding experiment

Steps to test this PR

Pre onboarding

  • Fresh install
  • Check background is updated
  • Check Dax dialogs UI is updated (new radius and edge)
  • Tap on "Let's do it"
  • Check comparison chart has new icons for each chart item
  • Check copy is updated
  • Tap on "Choose Your Browser" (doesn't matter if you set DDG as default or not)
  • Check new address bar position dialog appear
  • Check new pixel m_preonboarding_address_bar_position_dialog_shown_unique is fired
  • Tap on Bottom option
  • Tap on "Next"
  • Check new pixel m_preonboarding_bottom_address_bar_selected_unique is fired
    ...

Try a search Dax dialog

  • Check new "Try a search" dialog appear with updated UI (background, radius and edge)
  • Check dialog's copy is updated
  • Check there are only 3 search options
  • Tap on Surprise me! option
  • Check you navigate to baby ducklings search (images section)
    ...

SERP Dax dialog

  • Check updated SERP dialog is displayed
  • Check pixel m_odc_s is fired with parameter cta = s
  • Tap on a "Got it!"
    ...

Site suggestions Dax dialog

  • Check updated Site Suggestions dialog is displayed
  • Check pixel m_odc_s is fired with parameter cta = visit_site
  • Tap on 'Surprise me' site suggestion
    ...

Trackers Blocked Dax dialog

  • Check updated Trackers blocked Dax dialog is displayed
  • Check privacy shield is highlighted
  • Check pixel m_odc_s is fired with parameter cta = t
  • Tap on privacy shield
  • Go back to browser
  • Check highlight is gone
  • Tap on Got it! button
    ...

Fire Button Dax dialog

  • Check updated Fire Dax dialog with 2 buttons is displayed
  • Check pixel m_odc_s is fired with parameter cta = fd
  • Check fire button highlight is on
  • Tap on fire button
  • Check dialog is dismissed
  • Check fire button highlight is off
  • Tap on Clear Data
    ...

End onboarding dialog

  • Check updated end Dax dialog is shown in new tab

Fire Dax dialog 'Skip' button

  • Fresh install
  • Repeat all steps until seeing Fire Dax dialog again
  • Tap on 'Skip' secondary button
  • Check pixel m_onboarding_dax_cta_cancel is fired with parameter cta = fd
  • Check updated End dialog appear
  • Check pixel m_odc_s is fired with parameter cta = end

Fire Dax dialog 'Try it' button

  • Fresh install
  • Repeat all steps until seeing Fire Dax dialog again
  • Tap on 'Try it' secondary button
  • Check pixel m_odc_ok is fired with parameter cta = fd
  • Check Fire button options are displayed and highlight is removed
  • Tap on Cancel
  • Check Fire dialog has been dismissed
  • Check updated End dialog appear
  • Refresh site
  • Check updated End Dax dialog is displayed
  • Check pixel m_odc_s is fired with parameter cta = end

No Trackers Dax dialog

  • Fresh install
  • Go to wikipedia.org
  • Check no trackers Dax dialog has the new UI
  • Check pixel m_odc_s is fired with parameter cta = nt
    ...

Trackers Network Dax dialog

  • Go to facebook.com
  • Check network Dax dialog has the new UI
  • Check pixel m_odc_s is fired with parameter cta = n
    ...

Some UI changes

Before After
Screenshot_20250129_151641_DuckDuckGo Screenshot 2025-01-29 at 15 22 12
Screenshot 2025-01-29 at 15 17 14 Screenshot 2025-01-29 at 15 27 41
Screenshot 2025-01-29 at 15 17 31 Screenshot 2025-01-29 at 14 43 49
Screenshot 2025-01-29 at 15 17 54 Screenshot 2025-01-29 at 14 45 12

@nalcalag
Copy link
Contributor Author

nalcalag commented Jan 29, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nalcalag nalcalag marked this pull request as ready for review January 29, 2025 16:35
@nalcalag nalcalag requested a review from malmstein as a code owner January 29, 2025 16:35
@nalcalag nalcalag force-pushed the feature/noelia/release_highlight_onboarding_to_all_users branch from fd83923 to 5deffb0 Compare January 31, 2025 15:32
Copy link
Contributor

@anikiki anikiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected! 🎉

@nalcalag nalcalag force-pushed the feature/noelia/release_highlight_onboarding_to_all_users branch from 5deffb0 to a844aaf Compare February 3, 2025 13:22
@nalcalag nalcalag mentioned this pull request Feb 3, 2025
7 tasks
@nalcalag nalcalag force-pushed the feature/noelia/release_highlight_onboarding_to_all_users branch from a844aaf to 03de1c6 Compare February 3, 2025 13:22
@nalcalag nalcalag force-pushed the feature/noelia/release_highlight_onboarding_to_all_users branch from 03de1c6 to 9625e45 Compare February 3, 2025 15:14
Task/Issue URL:
https://app.asana.com/0/1201807753394693/1209307760721992

### Description
Remove highlight on fire button after Fire dialog is dismissed

### Steps to test this PR

- [ ] Fresh install
- [ ] Go to browser
- [ ] Go to a trackers website (e.g. bbc.co.uk)
- [ ] Tap on Got it! button
- [ ] Check Fire button is highlighted
- [ ] Tap on Skip
- [ ] Check Fire button highlight is removed


### No UI changes
@nalcalag nalcalag merged commit 14d78cf into develop Feb 4, 2025
6 checks passed
@nalcalag nalcalag deleted the feature/noelia/release_highlight_onboarding_to_all_users branch February 4, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants