Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure timeout-minutes for GH actions which run Maestro tests #5554

Merged

Conversation

CDRussell
Copy link
Member

@CDRussell CDRussell commented Jan 28, 2025

Task/Issue URL: https://app.asana.com/0/608920331025315/1209118297419133/f

Description

Adds timeout-minutes to all the steps which are triggering a Maestro test run on Robin.

  • we want timeouts to be treated as a failure, not for the CI to give up on a timeout and report as a success
  • configuring the timeouts this way gives us genuine timeouts that will fail the build if the timeout-minutes value is exceeded for that step.

Steps to test this PR

  • QA optional
  • From a manual test, i confirmed using this approach will successfully time out and fail the build if the Robin tests take too long to run 👇
Screenshot 2025-01-28 at 10 18 27

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@CDRussell CDRussell marked this pull request as ready for review January 28, 2025 10:41
@CDRussell CDRussell force-pushed the feature/craig/configure_timeouts_on_maestro_github_actions branch from 2f923fd to 9411074 Compare February 3, 2025 15:24
Copy link
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit on the variable

with:
api-key: ${{ secrets.ROBIN_API_KEY }}
project-id: ${{ vars.ROBIN_ANDROID_PROJECT_ID }}
name: androidDesignSystem_${{ github.sha }}
timeout: 120
timeout: 180
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: since we are using the same value for all different workflows, how would you feel about adding this value as a Variable? project-id: ${{ vars.ROBIN_TIMEOUT_MINUTES }}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Assuming there won't be any issues with it thinking it’s now a string instead of an int?

We’ll find out. 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a test run; seems fine

@CDRussell CDRussell merged commit 7ab5b00 into develop Feb 3, 2025
4 checks passed
@CDRussell CDRussell deleted the feature/craig/configure_timeouts_on_maestro_github_actions branch February 3, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants