Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE in onUserSubmittedQuery #5534

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Fix NPE in onUserSubmittedQuery #5534

merged 1 commit into from
Jan 27, 2025

Conversation

CrisBarreiro
Copy link
Contributor

@CrisBarreiro CrisBarreiro commented Jan 24, 2025 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1205008441501016/1209225018365506/f

Description

Steps to test this PR

No QA needed, not easy to reproduce

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)

@CrisBarreiro Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

nalcalag
nalcalag approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@nalcalag nalcalag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CrisBarreiro CrisBarreiro merged commit e8267da into develop Jan 27, 2025
8 checks passed
@CrisBarreiro CrisBarreiro deleted the fix/cris/npe-on-user-submitted-query branch January 27, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalcalag nalcalag nalcalag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CrisBarreiro @nalcalag