Autofill: Implement mapping for appPackages for autofill provider service #5508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlenDimla
requested review from
cmonfortep and
CDRussell
and removed request for
cmonfortep
|
Seems like the lint failures and unit test failures were on your changes @cmonfortep so I wouldn’t touch them. |
karlenDimla
force-pushed
the
feature/karl/autofill/mapping
branch
from
6c71bcf to
07a9784
Compare
CDRussell
reviewed
Jan 23, 2025
...fill-impl/src/main/java/com/duckduckgo/autofill/impl/service/mapper/AppCredentialProvider.kt
Show resolved
Hide resolved
...autofill-impl/src/main/java/com/duckduckgo/autofill/impl/service/mapper/AppToDomainMapper.kt
Outdated
Show resolved
Hide resolved
...ll-impl/src/main/java/com/duckduckgo/autofill/impl/service/mapper/PackageManagerExtension.kt
Outdated
Show resolved
Hide resolved
cmonfortep
force-pushed
the
feature/cristian/autofill/autofill_provider_poc
branch
from
e70f429 to
4cf2a64
Compare
cmonfortep
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Thanks @karlenDimla for the work here.
Left some comments. We need to rebase so the diff gets updated
.../autofill-impl/src/main/java/com/duckduckgo/autofill/impl/service/mapper/AssetLinksLoader.kt
Show resolved
Hide resolved
...ill-impl/src/main/java/com/duckduckgo/autofill/impl/service/mapper/AppFingerprintProvider.kt
Show resolved
Hide resolved
...fill-impl/src/main/java/com/duckduckgo/autofill/impl/service/mapper/AppCredentialProvider.kt
Show resolved
Hide resolved
...main/java/com/duckduckgo/autofill/impl/service/mapper/RemoteDomainTargetAppDataDownloader.kt
Show resolved
Hide resolved
...pl/src/main/java/com/duckduckgo/autofill/impl/service/mapper/RemoteDomainTargetAppService.kt
Outdated
Show resolved
Hide resolved
karlenDimla
force-pushed
the
feature/karl/autofill/mapping
branch
from
07a9784 to
cfa85e8
Compare
|
Addressed all comments (pending final endpoint). if you don’t mind manually running this https://app.asana.com/0/1201462763415876/1209196674121696/f would be helpful. Thanks! @cmonfortep @CDRussell |
cmonfortep
reviewed
Jan 27, 2025
...fill-impl/src/main/java/com/duckduckgo/autofill/impl/service/mapper/AppCredentialProvider.kt
Outdated
Show resolved
Hide resolved
...autofill-impl/src/main/java/com/duckduckgo/autofill/impl/service/mapper/AppToDomainMapper.kt
Outdated
Show resolved
Hide resolved
...pl/src/main/java/com/duckduckgo/autofill/impl/service/mapper/RemoteDomainTargetAppService.kt
Outdated
Show resolved
Hide resolved
cmonfortep
approved these changes
Jan 27, 2025
|
@cmonfortep Awesome! Feel free to merge then when ready. Thanks |
cmonfortep
force-pushed
the
feature/cristian/autofill/autofill_provider_poc
branch
from
4cf2a64 to
adc22eb
Compare
cmonfortep
force-pushed
the
feature/karl/autofill/mapping
branch
from
b10e715 to
7cb8a70
Compare
cmonfortep
force-pushed
the
feature/cristian/autofill/autofill_provider_poc
branch
from
1814778 to
3a16022
Compare
cmonfortep
force-pushed
the
feature/karl/autofill/mapping
branch
from
7cb8a70 to
650b8d6
Compare
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
cmonfortep
force-pushed
the
feature/cristian/autofill/autofill_provider_poc
branch
from
3a16022 to
8647864
Compare
cmonfortep
force-pushed
the
feature/karl/autofill/mapping
branch
3 times, most recently
from
5824f1f to
5d63aa5
Compare
14 tasks
cmonfortep
force-pushed
the
feature/cristian/autofill/autofill_provider_poc
branch
from
cb79246 to
12bf984
Compare
cmonfortep
force-pushed
the
feature/karl/autofill/mapping
branch
from
5d63aa5 to
810b9c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201462763415876/1209125943914364/f
Description
See attached task description
Steps to test this PR
https://app.asana.com/0/1201462763415876/1209196674121696/f