Multi-selection: Tab switcher #5464
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
42e94eb to
0d73e35
Compare
11 tasks
0nko
changed the title
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
0b382b2 to
8492b52
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
8492b52 to
c4c3cf8
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
2 times, most recently
from
c3270a9 to
e6e2148
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
e6e2148 to
ff15dd9
Compare
This was referenced Feb 3, 2025
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
ff15dd9 to
02fb482
Compare
0nko
requested review from
mikescamell
and removed request for
malmstein and
nalcalag
mikescamell
reviewed
Feb 13, 2025
Comment on lines
39
to
36
| @ContributesMultibinding( | ||
| scope = AppScope::class, | ||
| boundType = ApiInterceptorPlugin::class, | ||
| ) | ||
| class BlockListInterceptorApiPlugin @Inject constructor( | ||
| class BlockListInterceptorApiPlugin constructor( |
There was a problem hiding this comment.
❓ Why was this removed?
There was a problem hiding this comment.
Hmm, seems like this was added with a rebase.
mikescamell
approved these changes
Feb 13, 2025
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
2 times, most recently
from
eab74f4 to
3d62cf6
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
3d62cf6 to
01126c4
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
01126c4 to
b38ddf4
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
2 times, most recently
from
cca1829 to
da3cae9
Compare
0nko
force-pushed
the
feature/ondrej/tab-multi-selection
branch
from
8d39da7 to
c6a75d1
Compare
This was referenced Mar 31, 2025
Task/Issue URL: https://app.asana.com/0/72649045549333/1209118961868652 ### Description This pull request introduces significant changes to the tab management functionality in the `TabsDao` and `TabDataRepository` classes, as well as updates to the `TabSwitcherActivity` to support multi-tab selection and deletion. The main changes include the addition of new methods for handling multiple tabs and updates to the UI to reflect these changes. #### Tab Management Enhancements: * `TabsDao`: * Added `deleteTabs` method to delete multiple tabs by their IDs. * Added `markTabsAsDeletable` method to mark multiple tabs as deletable. * Added `undoDeletableTabs` method to undo the deletable status of multiple tabs. * Added `deleteTabsAndUpdateSelection` method to delete multiple tabs and update the tab selection. * `TabDataRepository`: * Introduced `deleteTabs` method to delete multiple tabs and clear their site data. * Introduced `markDeletable` method to mark multiple tabs as deletable. * Introduced `undoDeletable` method to undo the deletable status of multiple tabs. * Updated `purgeDeletableTabs` to clear site data if the multi-selection feature is enabled. #### UI Updates for Multi-Tab Selection: * `TabSwitcherActivity`: * Enhanced `updateToolbarTitle` to display the number of selected tabs. * Added logic to show a snackbar when tabs are deleted and allow undoing the deletion. [1](diffhunk://#diff-62a06ae9c304fc73ca47f7d6e81559a33e64c83a06bcec7b664985c6fc81d185L610-R620) [2](diffhunk://#diff-62a06ae9c304fc73ca47f7d6e81559a33e64c83a06bcec7b664985c6fc81d185R631-R641) * Updated `processCommand` to handle new commands for closing and deleting multiple tabs. * Added methods to show confirmation dialogs for closing all tabs or selected tabs. * Modified various methods to support the new multi-tab selection and deletion functionality. [1](diffhunk://#diff-62a06ae9c304fc73ca47f7d6e81559a33e64c83a06bcec7b664985c6fc81d185L561-R578) [2](diffhunk://#diff-62a06ae9c304fc73ca47f7d6e81559a33e64c83a06bcec7b664985c6fc81d185L574-R589) ### Steps to test this PR _Closing of all tabs in normal mode_ - [x] Prepare a few tabs beforehand - [x] Go to the tab switcher - [x] Tap on the more menu - [x] Tap on Close All Tabs - [x] Verify a confirmation dialog is shown - [x] Tap on Close tabs - [x] Verify all tabs are cleared, the tab switcher is closed and a NTP is loaded _Closing tabs in selection mode_ - [x] Prepare a few tabs beforehand - [x] Go to the tab switcher - [x] Tap on the more menu - [x] Tap on Select Tabs - [x] Select some (not all) tabs - [x] Tap on Close Tabs - [x] Verify a confirmation dialog is shown - [x] Tap on Close tabs - [x] Verify the selected tabs are closed - [x] Verify an undo snackbar is shown - [x] Tap on Undo - [x] Verify the the deleted tabs are restored _Closing "other tabs" in selection mode_ - [x] Prepare a few tabs beforehand - [x] Go to the tab switcher - [x] Tap on the more menu - [x] Tap on Select Tabs - [x] Select some (not all) tabs - [x] Tap on Close Other Tabs - [x] Verify a confirmation dialog is shown - [x] Tap on Close tabs - [x] Verify all tabs except the selected tabs are closed - [x] Verify an undo snackbar is shown - [x] Tap on Undo - [x] Verify the the deleted tabs are restored _Closing all tabs in selection mode_ - [x] Prepare a few tabs beforehand - [x] Go to the tab switcher - [x] Tap on the more menu - [x] Tap on Select Tabs - [x] Tap on the More menu and tap on Select All - [x] Verify all tabs are selected - [x] Tap on the Close Tabs FAB - [x] Verify a confirmation dialog is shown - [x] Tap on Close tabs - [x] Verify all tabs are cleared, the tab switcher is closed and a NTP is loaded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207418217763355/1209148925370449/f
Description
This PR is the feature branch for the tab switcher multi-selection project.
Steps to test this PR
Nothing to test, this will serve as a feature branch.