Second iteration for settings #3956
Merged
+531
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 1, 2023
Merged
Merged
Merged
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
|
@malmstein, @nalcalag FYI the CheckListItem changes are temporary until https://app.asana.com/0/488551667048375/1204723717455126/f is sorted |
marcosholgado
force-pushed
the
feature/marcos/add_netp_setting
branch
from
18f4949 to
36dd15e
Compare
marcosholgado
force-pushed
the
feature/marcos/subs_settings_it2
branch
from
db25aca to
da8f9cf
Compare
marcosholgado
force-pushed
the
feature/marcos/add_netp_setting
branch
from
36dd15e to
23b51b1
Compare
marcosholgado
force-pushed
the
feature/marcos/subs_settings_it2
branch
from
da8f9cf to
4c6dc49
Compare
marcosholgado
force-pushed
the
feature/marcos/add_netp_setting
branch
from
23b51b1 to
1d0844c
Compare
marcosholgado
force-pushed
the
feature/marcos/subs_settings_it2
branch
from
4c6dc49 to
300f109
Compare
marcosholgado
force-pushed
the
feature/marcos/subs_settings_it2
branch
from
300f109 to
f2d24e3
Compare
karlenDimla
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205820670085181/f
Description
See task
Steps to test this PR
See task