Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify public api to simplify code #3903

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

marcosholgado
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/488551667048375/1205984446323518/f

Description

This PR changes the messaging public API

Steps to test this PR

See task

@marcosholgado marcosholgado force-pushed the feature/marcos/change_js_messaging_api branch 2 times, most recently from df8097e to c9edd39 Compare November 22, 2023 09:41
Copy link
Collaborator

@aitorvs aitorvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcosholgado marcosholgado force-pushed the feature/marcos/fe_subs_purch branch from 719ae8b to bb47a69 Compare November 22, 2023 13:01
@marcosholgado marcosholgado force-pushed the feature/marcos/change_js_messaging_api branch from f68f3ab to d8adc82 Compare November 22, 2023 13:01
@marcosholgado marcosholgado force-pushed the feature/marcos/fe_subs_purch branch from bb47a69 to 401af35 Compare November 23, 2023 09:59
@marcosholgado marcosholgado force-pushed the feature/marcos/change_js_messaging_api branch 2 times, most recently from 3aa8674 to 1db76d7 Compare November 23, 2023 10:00
@marcosholgado marcosholgado force-pushed the feature/marcos/fe_subs_purch branch from 401af35 to 4b8d12e Compare November 24, 2023 11:29
@marcosholgado marcosholgado force-pushed the feature/marcos/change_js_messaging_api branch from 1db76d7 to 45547f7 Compare November 24, 2023 11:29
This was referenced Nov 24, 2023
Base automatically changed from feature/marcos/fe_subs_purch to develop November 24, 2023 15:14
@marcosholgado marcosholgado force-pushed the feature/marcos/change_js_messaging_api branch from 45547f7 to 6f36e55 Compare November 24, 2023 15:16
@marcosholgado marcosholgado merged commit 729a7a8 into develop Nov 24, 2023
5 checks passed
@marcosholgado marcosholgado deleted the feature/marcos/change_js_messaging_api branch November 24, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants