Improve handling for snooze state #3898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 21, 2023
Merged
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
karlenDimla
force-pushed
the
feature/aitor/vpn/snooze
branch
from
2e590dd to
34954a6
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/snooze-improve-store-state
branch
from
9cbe5e2 to
d45d53d
Compare
karlenDimla
force-pushed
the
feature/aitor/vpn/snooze
branch
from
34954a6 to
e88dfac
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/snooze-improve-store-state
branch
3 times, most recently
from
efb9415 to
817ecb6
Compare
karlenDimla
changed the title
karlenDimla
force-pushed
the
feature/karl/vpn/snooze-improve-store-state
branch
from
817ecb6 to
49812f2
Compare
karlenDimla
commented
Nov 22, 2023
...in/java/com/duckduckgo/mobile/android/vpn/ui/tracker_activity/DeviceShieldTrackerActivity.kt
Outdated
Show resolved
Hide resolved
karlenDimla
force-pushed
the
feature/aitor/vpn/snooze
branch
from
e88dfac to
35d24a1
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/snooze-improve-store-state
branch
from
49812f2 to
aee4030
Compare
aitorvs
reviewed
Nov 22, 2023
...pn-impl/src/main/java/com/duckduckgo/mobile/android/vpn/service/TrackerBlockingVpnService.kt
Outdated
Show resolved
Hide resolved
...-protection/vpn-api/src/main/java/com/duckduckgo/mobile/android/vpn/state/VpnStateMonitor.kt
Outdated
Show resolved
Hide resolved
...pn-impl/src/main/java/com/duckduckgo/mobile/android/vpn/service/state/RealVpnStateMonitor.kt
Outdated
Show resolved
Hide resolved
karlenDimla
force-pushed
the
feature/aitor/vpn/snooze
branch
from
8294e6a to
b02fd3d
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/snooze-improve-store-state
branch
from
aee4030 to
c595ca2
Compare
karlenDimla
added a commit
that referenced
this pull request
Nov 29, 2023
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) If your PR does not involve UI changes, you can remove the **UI changes** section At a minimum, make sure your changes are tested in API 23 and one of the more recent API levels available. --> Task/Issue URL: https://app.asana.com/0/0/1206000100414553/f ### Description Improve VPNServiceState to avoid hardcoding snooze duration and define it in a single place only. ### Steps to test this PR repeat https://app.asana.com/0/0/1205989766118758/f
karlenDimla
added a commit
that referenced
this pull request
Dec 4, 2023
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) If your PR does not involve UI changes, you can remove the **UI changes** section At a minimum, make sure your changes are tested in API 23 and one of the more recent API levels available. --> Task/Issue URL: https://app.asana.com/0/0/1206000100414553/f ### Description Improve VPNServiceState to avoid hardcoding snooze duration and define it in a single place only. ### Steps to test this PR repeat https://app.asana.com/0/0/1205989766118758/f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206000100414553/f
Description
Improve VPNServiceState to avoid hardcoding snooze duration and define it in a single place only.
Steps to test this PR
repeat https://app.asana.com/0/0/1205989766118758/f