Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pixels for snooze #3897

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

karlenDimla
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/0/1205947647495715/f

Description

See attached task description

Steps to test this PR

https://app.asana.com/0/0/1206000100414551/f

@karlenDimla
Copy link
Contributor Author

karlenDimla commented Nov 21, 2023

Copy link
Collaborator

@aitorvs aitorvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment as discussed

@karlenDimla karlenDimla force-pushed the feature/aitor/vpn/snooze branch from e88dfac to 35d24a1 Compare November 22, 2023 17:06
@karlenDimla karlenDimla force-pushed the feature/karl/vpn/snooze-pixels branch from 6009319 to 5b37b97 Compare November 22, 2023 17:06
@karlenDimla karlenDimla merged commit 0ab9e00 into feature/aitor/vpn/snooze Nov 23, 2023
4 checks passed
@karlenDimla karlenDimla deleted the feature/karl/vpn/snooze-pixels branch November 23, 2023 11:24
karlenDimla added a commit that referenced this pull request Nov 29, 2023
<!--
Note: This checklist is a reminder of our shared engineering
expectations.
The items in Bold are required
If your PR involves UI changes:
1. Upload screenshots or screencasts that illustrate the changes before
/ after
2. Add them under the UI changes section (feel free to add more columns
if needed)
If your PR does not involve UI changes, you can remove the **UI
changes** section

At a minimum, make sure your changes are tested in API 23 and one of the
more recent API levels available.
-->

Task/Issue URL: https://app.asana.com/0/0/1205947647495715/f

### Description
See attached task description

### Steps to test this PR
https://app.asana.com/0/0/1206000100414551/f
karlenDimla added a commit that referenced this pull request Dec 4, 2023
<!--
Note: This checklist is a reminder of our shared engineering
expectations.
The items in Bold are required
If your PR involves UI changes:
1. Upload screenshots or screencasts that illustrate the changes before
/ after
2. Add them under the UI changes section (feel free to add more columns
if needed)
If your PR does not involve UI changes, you can remove the **UI
changes** section

At a minimum, make sure your changes are tested in API 23 and one of the
more recent API levels available.
-->

Task/Issue URL: https://app.asana.com/0/0/1205947647495715/f

### Description
See attached task description

### Steps to test this PR
https://app.asana.com/0/0/1206000100414551/f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants