-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pixels for snooze #3897
Merged
karlenDimla
merged 2 commits into
feature/aitor/vpn/snooze
from
feature/karl/vpn/snooze-pixels
Nov 23, 2023
Merged
Add pixels for snooze #3897
karlenDimla
merged 2 commits into
feature/aitor/vpn/snooze
from
feature/karl/vpn/snooze-pixels
Nov 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
karlenDimla
force-pushed
the
feature/aitor/vpn/snooze
branch
from
November 21, 2023 15:14
2e590dd
to
34954a6
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/snooze-pixels
branch
from
November 21, 2023 15:14
c8dd24a
to
a766f96
Compare
karlenDimla
force-pushed
the
feature/aitor/vpn/snooze
branch
from
November 22, 2023 12:47
34954a6
to
e88dfac
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/snooze-pixels
branch
from
November 22, 2023 12:47
a766f96
to
73e5c44
Compare
aitorvs
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a comment as discussed
...-impl/src/main/java/com/duckduckgo/networkprotection/impl/notification/NetPEnableReceiver.kt
Outdated
Show resolved
Hide resolved
karlenDimla
force-pushed
the
feature/aitor/vpn/snooze
branch
from
November 22, 2023 17:06
e88dfac
to
35d24a1
Compare
karlenDimla
force-pushed
the
feature/karl/vpn/snooze-pixels
branch
from
November 22, 2023 17:06
6009319
to
5b37b97
Compare
karlenDimla
added a commit
that referenced
this pull request
Nov 29, 2023
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) If your PR does not involve UI changes, you can remove the **UI changes** section At a minimum, make sure your changes are tested in API 23 and one of the more recent API levels available. --> Task/Issue URL: https://app.asana.com/0/0/1205947647495715/f ### Description See attached task description ### Steps to test this PR https://app.asana.com/0/0/1206000100414551/f
karlenDimla
added a commit
that referenced
this pull request
Dec 4, 2023
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) If your PR does not involve UI changes, you can remove the **UI changes** section At a minimum, make sure your changes are tested in API 23 and one of the more recent API levels available. --> Task/Issue URL: https://app.asana.com/0/0/1205947647495715/f ### Description See attached task description ### Steps to test this PR https://app.asana.com/0/0/1206000100414551/f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205947647495715/f
Description
See attached task description
Steps to test this PR
https://app.asana.com/0/0/1206000100414551/f