Attempt to fix test failing due to exceeding 10s timeout #3884
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205977462737331/f
Description
Attempt at fixing the timeout occasionally experienced because of the new 10s
runTest
execution timeout.While reviewing the failing tests, two things sprung to mind:
whenTrackingParametersDetectedAndIsForMainFrameAndIsAppLinkAndAppLinkIsHandledThenReturnTrueAndLoadCleanedUrl
is suspect, because it's a test, but it's also called from inside another test. This would result in a nestedrunTest
. This isn't fixed in this PR yet (if the tests pass, will defer changing it)WebView
which is a slow operation (over 1.5s on my fast local setup).runTest
anywaySteps to test this PR
Feature 1