Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix test failing due to exceeding 10s timeout #3884

Conversation

CDRussell
Copy link
Member

@CDRussell CDRussell commented Nov 17, 2023

Task/Issue URL: https://app.asana.com/0/0/1205977462737331/f

Description

Attempt at fixing the timeout occasionally experienced because of the new 10s runTest execution timeout.

While reviewing the failing tests, two things sprung to mind:

  • whenTrackingParametersDetectedAndIsForMainFrameAndIsAppLinkAndAppLinkIsHandledThenReturnTrueAndLoadCleanedUrl is suspect, because it's a test, but it's also called from inside another test. This would result in a nested runTest. This isn't fixed in this PR yet (if the tests pass, will defer changing it)
  • there are many tests which mock a WebView which is a slow operation (over 1.5s on my fast local setup).
    • Feasible this could result in tripping the 10s threshold on CI.
    • But also, none of the tests seem to require runTest anyway

Steps to test this PR

Feature 1

  • CI passes

@CDRussell CDRussell mentioned this pull request Nov 17, 2023
1 task
@CDRussell
Copy link
Member Author

Copy link
Contributor

@joshliebe joshliebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@CDRussell CDRussell marked this pull request as ready for review November 17, 2023 16:56
@CDRussell CDRussell merged commit 43948d5 into feature/josh/update-to-kotlin-1.9 Nov 17, 2023
@CDRussell CDRussell deleted the feature/craig/fix-slow-test-attempt-for-kotlin-1.9 branch November 17, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants