Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null pointers in unit tests #3883

Conversation

CDRussell
Copy link
Member

@CDRussell CDRussell commented Nov 17, 2023

Task/Issue URL: https://app.asana.com/0/0/1205977462737330/f

Description

Fixes NPE which happen after updating to Kotlin 1.9

Steps to test this PR

QA-optional

@CDRussell CDRussell mentioned this pull request Nov 17, 2023
1 task
@CDRussell
Copy link
Member Author

CDRussell commented Nov 17, 2023

Copy link
Contributor

@joshliebe joshliebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😁

@CDRussell CDRussell marked this pull request as ready for review November 17, 2023 15:38
@CDRussell
Copy link
Member Author

CI failed due to known issue (kotlinx.coroutines.test.UncompletedCoroutinesError: After waiting for 10s, the test coroutine is not completing). Merging anyway, and will fix in the lower branch of the stack.

@CDRussell CDRussell merged commit 7ba3e3b into feature/josh/update-to-kotlin-1.9 Nov 17, 2023
@CDRussell CDRussell deleted the feature/craig/kotlin-1.9-test-fixes branch November 17, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants