Update autofill dialog copy, changing "logins" to "passwords" #3867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 15, 2023
Merged
Suppress system AutofillService save prompts to prevent it overlapping in-browser save prompts
#3840
Merged
This was referenced Nov 15, 2023
CDRussell
force-pushed
the
feature/craig/update_copy_for_autofill_dialogs
branch
from
4e0ad24 to
6f4923e
Compare
CDRussell
added a commit
that referenced
this pull request
Nov 15, 2023
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) If your PR does not involve UI changes, you can remove the **UI changes** section At a minimum, make sure your changes are tested in API 23 and one of the more recent API levels available. --> Task/Issue URL: https://app.asana.com/0/0/1205900373687630/f ### Description Updates copy, preferring to use terminology "password" instead of "login" in the autofill dialogs. Includes translations. ### Steps to test this PR - QA optional Co-authored-by: root <root@10.100.11.5>
CDRussell
added a commit
that referenced
this pull request
Nov 15, 2023
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) If your PR does not involve UI changes, you can remove the **UI changes** section At a minimum, make sure your changes are tested in API 23 and one of the more recent API levels available. --> Task/Issue URL: https://app.asana.com/0/0/1205900373687630/f ### Description Updates copy, preferring to use terminology "password" instead of "login" in the autofill dialogs. Includes translations. ### Steps to test this PR - QA optional Co-authored-by: root <root@10.100.11.5>
CDRussell
added a commit
that referenced
this pull request
Nov 15, 2023
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) If your PR does not involve UI changes, you can remove the **UI changes** section At a minimum, make sure your changes are tested in API 23 and one of the more recent API levels available. --> Task/Issue URL: https://app.asana.com/0/0/1205900373687630/f ### Description Updates copy, preferring to use terminology "password" instead of "login" in the autofill dialogs. Includes translations. ### Steps to test this PR - QA optional Co-authored-by: root <root@10.100.11.5>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205900373687630/f
Description
Updates copy, preferring to use terminology "password" instead of "login" in the autofill dialogs.
Includes translations.
Steps to test this PR