Fix bug: should use sdkInt as the property to compare #3865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 14, 2023
Merged
This was referenced Nov 14, 2023
cmonfortep
approved these changes
Nov 14, 2023
CrisBarreiro
approved these changes
Nov 14, 2023
CDRussell
deleted the
fix/craig/use_sdk_int_check_instead_of_app_version
branch
CDRussell
added a commit
that referenced
this pull request
Nov 15, 2023
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) If your PR does not involve UI changes, you can remove the **UI changes** section At a minimum, make sure your changes are tested in API 23 and one of the more recent API levels available. --> Task/Issue URL: https://app.asana.com/0/0/1205952041108121/f ### Description Bug fix: - replaces `appBuildConfig.versionCode` with `appBuildConfig.sdkInt` in the OS version guard. ### Steps to test this PR QA optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205952041108121/f
Description
Bug fix:
appBuildConfig.versionCodewithappBuildConfig.sdkIntin the OS version guard.Steps to test this PR
QA optional