Bookmarks: Undo behavior #3828
Merged
Bookmarks: Undo behavior #3828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malmstein
force-pushed
the
08-30-Bookmarks_Undo_behavior
branch
from
b38d8e8 to
cd16c21
Compare
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
malmstein
force-pushed
the
08-30-Bookmarks_Undo_behavior
branch
3 times, most recently
from
62c0291 to
f1133b2
Compare
cmonfortep
reviewed
Nov 16, 2023
There was a problem hiding this comment.
I have a few comments I would like to review together:
- Move logic out of the UI, and keep viewmodel methods agnostic.
- We don't have a consitent way to hide savedsites/folders. One implementation for Bookmarks screen, and different implementations for BrowserTab and SystemSearch screens. I think we should unify the logic (posted a proposal, let's review if that will work)
app/src/main/java/com/duckduckgo/app/bookmarks/ui/BookmarksActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/bookmarks/ui/BookmarksActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/systemsearch/SystemSearchActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/systemsearch/SystemSearchViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/bookmarks/ui/BookmarksViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/bookmarks/ui/BookmarksViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/bookmarks/ui/BookmarksActivity.kt
Outdated
Show resolved
Hide resolved
malmstein
force-pushed
the
08-30-Bookmarks_Undo_behavior
branch
2 times, most recently
from
cf0cf20 to
a1db403
Compare
cmonfortep
approved these changes
Nov 20, 2023
app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/systemsearch/SystemSearchViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/systemsearch/SystemSearchViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/test/java/com/duckduckgo/app/systemsearch/SystemSearchViewModelTest.kt
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/systemsearch/SystemSearchActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/systemsearch/SystemSearchActivity.kt
Outdated
Show resolved
Hide resolved
malmstein
force-pushed
the
08-30-Bookmarks_Undo_behavior
branch
from
3562a65 to
ffd2edd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1205171041444238/f
Description
This PR changes how undo works at a UI layer level for saved sites.
Until now, when the user wanted to delete a bookmark, we were directly removing it from the DB. In the case that the user were to undo the change, we were adding a new row to the DB. This is problematic in many levels, changing order of Favourites and also triggering unnecessary Sync operations.
Steps to test this PR
All test cases assume that Sync is enabled
Remove Favourite from Bookmarks screen
Remove Bookmark from Browser
Remove Favourite from Browser
Remove Bookmark from Browser
Remove Favourite from New Tab
Remove Favourite from Omnibar Quick Access
Remove Favourite from Favourites Widget