Apply max-width constraints to autofill dialogs' contents #3773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 30, 2023
Merged
This was referenced Oct 30, 2023
CDRussell
force-pushed
the
feature/craig/autofill_max_width_on_prompts
branch
from
882733a to
ee077a0
Compare
CDRussell
force-pushed
the
feature/craig/autofill_enabled_by_default
branch
from
41fd748 to
1aae7f9
Compare
CDRussell
force-pushed
the
feature/craig/autofill_max_width_on_prompts
branch
3 times, most recently
from
eea6315 to
4a94337
Compare
CDRussell
force-pushed
the
feature/craig/autofill_enabled_by_default
branch
from
1aae7f9 to
9367453
Compare
CDRussell
force-pushed
the
feature/craig/autofill_max_width_on_prompts
branch
from
4a94337 to
f84a926
Compare
joshliebe
reviewed
Oct 31, 2023
joshliebe
approved these changes
Oct 31, 2023
CDRussell
force-pushed
the
feature/craig/autofill_max_width_on_prompts
branch
from
f84a926 to
8da2f2c
Compare
CDRussell
added a commit
that referenced
this pull request
Nov 1, 2023
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) If your PR does not involve UI changes, you can remove the **UI changes** section At a minimum, make sure your changes are tested in API 23 and one of the more recent API levels available. --> Task/Issue URL: https://app.asana.com/0/0/1205495150811754/f ### Description We want to apply a max-width constraint to the contents of the autofill dialogs. Some of the autofill dialogs had different ways of constraining content before, and others had none; this PR consolidates them all into using this approach: - Guideline left set to 10% from left edge of dialog, guideline right set to 10% from right edge of dialog - Autofill dialog content can use the remaining 80% of dialog width, up to max of `480dp` ℹ️ Note for reviewing the PR: - a lot of the _changes_ are caused by indentation as views are now inside another view group - tip: hide whitespace differences to see only what's actually changed, ignoring the change indentation <img width="249" alt="Screenshot 2023-10-31 at 12 34 27" src="https://github.com/duckduckgo/Android/assets/1336281/f19f99f0-6b02-4d3a-9810-4d2a4719432c"> ### Steps to test this PR _Save login prompt_ - [x] Visit https://fill.dev/form/login-simple and enter username [`abcd`] and password (>= 4 chars) - [x] Verify save prompt looks ok _Select login prompt_ - [x] Visit https://fill.dev/form/login-simple again - [x] verify prompt to login with saved credential looks ok _Update login prompt_ - [x] Visit https://fill.dev/form/login-simple again and dismiss any prompts to use a saved login - [x] Instead, enter same username as before `abcd` and a new password - [x] Verify the update login prompt looks ok _Generate password prompt_ - [x] Visit https://fill.dev/form/registration-email and tap on password field - [x] Verify generate password prompts looks ok _Email protection in-context signup_ - [x] Visit https://fill.dev/form/registration-email when you're **not** signed into email protection (requires device to be in English locale) - [x] Tap on grey Dax in email field; verify the prompt to sign up for email protection looks ok _Email protection, signed in state_ - [x] Sign into email protection (doesn't matter how you sign in, in-context or normal approach from settings) - [x] Visit https://fill.dev/form/registration-email again, and tap on email field - [x] Verify the prompt to use Email Protection looks ok ### UI changes Screenshots available [here](https://app.asana.com/0/0/1205842983551006/f) for phones and tablets, portrait and landscape
CDRussell
added a commit
that referenced
this pull request
Nov 6, 2023
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) If your PR does not involve UI changes, you can remove the **UI changes** section At a minimum, make sure your changes are tested in API 23 and one of the more recent API levels available. --> Task/Issue URL: https://app.asana.com/0/0/1205495150811754/f ### Description We want to apply a max-width constraint to the contents of the autofill dialogs. Some of the autofill dialogs had different ways of constraining content before, and others had none; this PR consolidates them all into using this approach: - Guideline left set to 10% from left edge of dialog, guideline right set to 10% from right edge of dialog - Autofill dialog content can use the remaining 80% of dialog width, up to max of `480dp` ℹ️ Note for reviewing the PR: - a lot of the _changes_ are caused by indentation as views are now inside another view group - tip: hide whitespace differences to see only what's actually changed, ignoring the change indentation <img width="249" alt="Screenshot 2023-10-31 at 12 34 27" src="https://github.com/duckduckgo/Android/assets/1336281/f19f99f0-6b02-4d3a-9810-4d2a4719432c"> ### Steps to test this PR _Save login prompt_ - [x] Visit https://fill.dev/form/login-simple and enter username [`abcd`] and password (>= 4 chars) - [x] Verify save prompt looks ok _Select login prompt_ - [x] Visit https://fill.dev/form/login-simple again - [x] verify prompt to login with saved credential looks ok _Update login prompt_ - [x] Visit https://fill.dev/form/login-simple again and dismiss any prompts to use a saved login - [x] Instead, enter same username as before `abcd` and a new password - [x] Verify the update login prompt looks ok _Generate password prompt_ - [x] Visit https://fill.dev/form/registration-email and tap on password field - [x] Verify generate password prompts looks ok _Email protection in-context signup_ - [x] Visit https://fill.dev/form/registration-email when you're **not** signed into email protection (requires device to be in English locale) - [x] Tap on grey Dax in email field; verify the prompt to sign up for email protection looks ok _Email protection, signed in state_ - [x] Sign into email protection (doesn't matter how you sign in, in-context or normal approach from settings) - [x] Visit https://fill.dev/form/registration-email again, and tap on email field - [x] Verify the prompt to use Email Protection looks ok ### UI changes Screenshots available [here](https://app.asana.com/0/0/1205842983551006/f) for phones and tablets, portrait and landscape
6 tasks
CDRussell
added a commit
that referenced
this pull request
Nov 7, 2023
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) If your PR does not involve UI changes, you can remove the **UI changes** section At a minimum, make sure your changes are tested in API 23 and one of the more recent API levels available. --> Task/Issue URL: https://app.asana.com/0/0/1205495150811754/f ### Description We want to apply a max-width constraint to the contents of the autofill dialogs. Some of the autofill dialogs had different ways of constraining content before, and others had none; this PR consolidates them all into using this approach: - Guideline left set to 10% from left edge of dialog, guideline right set to 10% from right edge of dialog - Autofill dialog content can use the remaining 80% of dialog width, up to max of `480dp` ℹ️ Note for reviewing the PR: - a lot of the _changes_ are caused by indentation as views are now inside another view group - tip: hide whitespace differences to see only what's actually changed, ignoring the change indentation <img width="249" alt="Screenshot 2023-10-31 at 12 34 27" src="https://github.com/duckduckgo/Android/assets/1336281/f19f99f0-6b02-4d3a-9810-4d2a4719432c"> ### Steps to test this PR _Save login prompt_ - [x] Visit https://fill.dev/form/login-simple and enter username [`abcd`] and password (>= 4 chars) - [x] Verify save prompt looks ok _Select login prompt_ - [x] Visit https://fill.dev/form/login-simple again - [x] verify prompt to login with saved credential looks ok _Update login prompt_ - [x] Visit https://fill.dev/form/login-simple again and dismiss any prompts to use a saved login - [x] Instead, enter same username as before `abcd` and a new password - [x] Verify the update login prompt looks ok _Generate password prompt_ - [x] Visit https://fill.dev/form/registration-email and tap on password field - [x] Verify generate password prompts looks ok _Email protection in-context signup_ - [x] Visit https://fill.dev/form/registration-email when you're **not** signed into email protection (requires device to be in English locale) - [x] Tap on grey Dax in email field; verify the prompt to sign up for email protection looks ok _Email protection, signed in state_ - [x] Sign into email protection (doesn't matter how you sign in, in-context or normal approach from settings) - [x] Visit https://fill.dev/form/registration-email again, and tap on email field - [x] Verify the prompt to use Email Protection looks ok ### UI changes Screenshots available [here](https://app.asana.com/0/0/1205842983551006/f) for phones and tablets, portrait and landscape
CDRussell
added a commit
that referenced
this pull request
Nov 7, 2023
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) If your PR does not involve UI changes, you can remove the **UI changes** section At a minimum, make sure your changes are tested in API 23 and one of the more recent API levels available. --> Task/Issue URL: https://app.asana.com/0/0/1205495150811754/f ### Description We want to apply a max-width constraint to the contents of the autofill dialogs. Some of the autofill dialogs had different ways of constraining content before, and others had none; this PR consolidates them all into using this approach: - Guideline left set to 10% from left edge of dialog, guideline right set to 10% from right edge of dialog - Autofill dialog content can use the remaining 80% of dialog width, up to max of `480dp` ℹ️ Note for reviewing the PR: - a lot of the _changes_ are caused by indentation as views are now inside another view group - tip: hide whitespace differences to see only what's actually changed, ignoring the change indentation <img width="249" alt="Screenshot 2023-10-31 at 12 34 27" src="https://github.com/duckduckgo/Android/assets/1336281/f19f99f0-6b02-4d3a-9810-4d2a4719432c"> ### Steps to test this PR _Save login prompt_ - [x] Visit https://fill.dev/form/login-simple and enter username [`abcd`] and password (>= 4 chars) - [x] Verify save prompt looks ok _Select login prompt_ - [x] Visit https://fill.dev/form/login-simple again - [x] verify prompt to login with saved credential looks ok _Update login prompt_ - [x] Visit https://fill.dev/form/login-simple again and dismiss any prompts to use a saved login - [x] Instead, enter same username as before `abcd` and a new password - [x] Verify the update login prompt looks ok _Generate password prompt_ - [x] Visit https://fill.dev/form/registration-email and tap on password field - [x] Verify generate password prompts looks ok _Email protection in-context signup_ - [x] Visit https://fill.dev/form/registration-email when you're **not** signed into email protection (requires device to be in English locale) - [x] Tap on grey Dax in email field; verify the prompt to sign up for email protection looks ok _Email protection, signed in state_ - [x] Sign into email protection (doesn't matter how you sign in, in-context or normal approach from settings) - [x] Visit https://fill.dev/form/registration-email again, and tap on email field - [x] Verify the prompt to use Email Protection looks ok ### UI changes Screenshots available [here](https://app.asana.com/0/0/1205842983551006/f) for phones and tablets, portrait and landscape
CDRussell
added a commit
that referenced
this pull request
Nov 8, 2023
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) If your PR does not involve UI changes, you can remove the **UI changes** section At a minimum, make sure your changes are tested in API 23 and one of the more recent API levels available. --> Task/Issue URL: https://app.asana.com/0/0/1205495150811754/f ### Description We want to apply a max-width constraint to the contents of the autofill dialogs. Some of the autofill dialogs had different ways of constraining content before, and others had none; this PR consolidates them all into using this approach: - Guideline left set to 10% from left edge of dialog, guideline right set to 10% from right edge of dialog - Autofill dialog content can use the remaining 80% of dialog width, up to max of `480dp` ℹ️ Note for reviewing the PR: - a lot of the _changes_ are caused by indentation as views are now inside another view group - tip: hide whitespace differences to see only what's actually changed, ignoring the change indentation <img width="249" alt="Screenshot 2023-10-31 at 12 34 27" src="https://github.com/duckduckgo/Android/assets/1336281/f19f99f0-6b02-4d3a-9810-4d2a4719432c"> ### Steps to test this PR _Save login prompt_ - [x] Visit https://fill.dev/form/login-simple and enter username [`abcd`] and password (>= 4 chars) - [x] Verify save prompt looks ok _Select login prompt_ - [x] Visit https://fill.dev/form/login-simple again - [x] verify prompt to login with saved credential looks ok _Update login prompt_ - [x] Visit https://fill.dev/form/login-simple again and dismiss any prompts to use a saved login - [x] Instead, enter same username as before `abcd` and a new password - [x] Verify the update login prompt looks ok _Generate password prompt_ - [x] Visit https://fill.dev/form/registration-email and tap on password field - [x] Verify generate password prompts looks ok _Email protection in-context signup_ - [x] Visit https://fill.dev/form/registration-email when you're **not** signed into email protection (requires device to be in English locale) - [x] Tap on grey Dax in email field; verify the prompt to sign up for email protection looks ok _Email protection, signed in state_ - [x] Sign into email protection (doesn't matter how you sign in, in-context or normal approach from settings) - [x] Visit https://fill.dev/form/registration-email again, and tap on email field - [x] Verify the prompt to use Email Protection looks ok ### UI changes Screenshots available [here](https://app.asana.com/0/0/1205842983551006/f) for phones and tablets, portrait and landscape
CDRussell
added a commit
that referenced
this pull request
Nov 10, 2023
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) If your PR does not involve UI changes, you can remove the **UI changes** section At a minimum, make sure your changes are tested in API 23 and one of the more recent API levels available. --> Task/Issue URL: https://app.asana.com/0/0/1205495150811754/f ### Description We want to apply a max-width constraint to the contents of the autofill dialogs. Some of the autofill dialogs had different ways of constraining content before, and others had none; this PR consolidates them all into using this approach: - Guideline left set to 10% from left edge of dialog, guideline right set to 10% from right edge of dialog - Autofill dialog content can use the remaining 80% of dialog width, up to max of `480dp` ℹ️ Note for reviewing the PR: - a lot of the _changes_ are caused by indentation as views are now inside another view group - tip: hide whitespace differences to see only what's actually changed, ignoring the change indentation <img width="249" alt="Screenshot 2023-10-31 at 12 34 27" src="https://github.com/duckduckgo/Android/assets/1336281/f19f99f0-6b02-4d3a-9810-4d2a4719432c"> ### Steps to test this PR _Save login prompt_ - [x] Visit https://fill.dev/form/login-simple and enter username [`abcd`] and password (>= 4 chars) - [x] Verify save prompt looks ok _Select login prompt_ - [x] Visit https://fill.dev/form/login-simple again - [x] verify prompt to login with saved credential looks ok _Update login prompt_ - [x] Visit https://fill.dev/form/login-simple again and dismiss any prompts to use a saved login - [x] Instead, enter same username as before `abcd` and a new password - [x] Verify the update login prompt looks ok _Generate password prompt_ - [x] Visit https://fill.dev/form/registration-email and tap on password field - [x] Verify generate password prompts looks ok _Email protection in-context signup_ - [x] Visit https://fill.dev/form/registration-email when you're **not** signed into email protection (requires device to be in English locale) - [x] Tap on grey Dax in email field; verify the prompt to sign up for email protection looks ok _Email protection, signed in state_ - [x] Sign into email protection (doesn't matter how you sign in, in-context or normal approach from settings) - [x] Visit https://fill.dev/form/registration-email again, and tap on email field - [x] Verify the prompt to use Email Protection looks ok ### UI changes Screenshots available [here](https://app.asana.com/0/0/1205842983551006/f) for phones and tablets, portrait and landscape
CDRussell
added a commit
that referenced
this pull request
Nov 10, 2023
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) If your PR does not involve UI changes, you can remove the **UI changes** section At a minimum, make sure your changes are tested in API 23 and one of the more recent API levels available. --> Task/Issue URL: https://app.asana.com/0/0/1205495150811754/f ### Description We want to apply a max-width constraint to the contents of the autofill dialogs. Some of the autofill dialogs had different ways of constraining content before, and others had none; this PR consolidates them all into using this approach: - Guideline left set to 10% from left edge of dialog, guideline right set to 10% from right edge of dialog - Autofill dialog content can use the remaining 80% of dialog width, up to max of `480dp` ℹ️ Note for reviewing the PR: - a lot of the _changes_ are caused by indentation as views are now inside another view group - tip: hide whitespace differences to see only what's actually changed, ignoring the change indentation <img width="249" alt="Screenshot 2023-10-31 at 12 34 27" src="https://github.com/duckduckgo/Android/assets/1336281/f19f99f0-6b02-4d3a-9810-4d2a4719432c"> ### Steps to test this PR _Save login prompt_ - [x] Visit https://fill.dev/form/login-simple and enter username [`abcd`] and password (>= 4 chars) - [x] Verify save prompt looks ok _Select login prompt_ - [x] Visit https://fill.dev/form/login-simple again - [x] verify prompt to login with saved credential looks ok _Update login prompt_ - [x] Visit https://fill.dev/form/login-simple again and dismiss any prompts to use a saved login - [x] Instead, enter same username as before `abcd` and a new password - [x] Verify the update login prompt looks ok _Generate password prompt_ - [x] Visit https://fill.dev/form/registration-email and tap on password field - [x] Verify generate password prompts looks ok _Email protection in-context signup_ - [x] Visit https://fill.dev/form/registration-email when you're **not** signed into email protection (requires device to be in English locale) - [x] Tap on grey Dax in email field; verify the prompt to sign up for email protection looks ok _Email protection, signed in state_ - [x] Sign into email protection (doesn't matter how you sign in, in-context or normal approach from settings) - [x] Visit https://fill.dev/form/registration-email again, and tap on email field - [x] Verify the prompt to use Email Protection looks ok ### UI changes Screenshots available [here](https://app.asana.com/0/0/1205842983551006/f) for phones and tablets, portrait and landscape
CDRussell
added a commit
that referenced
this pull request
Nov 14, 2023
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) If your PR does not involve UI changes, you can remove the **UI changes** section At a minimum, make sure your changes are tested in API 23 and one of the more recent API levels available. --> Task/Issue URL: https://app.asana.com/0/0/1205495150811754/f ### Description We want to apply a max-width constraint to the contents of the autofill dialogs. Some of the autofill dialogs had different ways of constraining content before, and others had none; this PR consolidates them all into using this approach: - Guideline left set to 10% from left edge of dialog, guideline right set to 10% from right edge of dialog - Autofill dialog content can use the remaining 80% of dialog width, up to max of `480dp` ℹ️ Note for reviewing the PR: - a lot of the _changes_ are caused by indentation as views are now inside another view group - tip: hide whitespace differences to see only what's actually changed, ignoring the change indentation <img width="249" alt="Screenshot 2023-10-31 at 12 34 27" src="https://github.com/duckduckgo/Android/assets/1336281/f19f99f0-6b02-4d3a-9810-4d2a4719432c"> ### Steps to test this PR _Save login prompt_ - [x] Visit https://fill.dev/form/login-simple and enter username [`abcd`] and password (>= 4 chars) - [x] Verify save prompt looks ok _Select login prompt_ - [x] Visit https://fill.dev/form/login-simple again - [x] verify prompt to login with saved credential looks ok _Update login prompt_ - [x] Visit https://fill.dev/form/login-simple again and dismiss any prompts to use a saved login - [x] Instead, enter same username as before `abcd` and a new password - [x] Verify the update login prompt looks ok _Generate password prompt_ - [x] Visit https://fill.dev/form/registration-email and tap on password field - [x] Verify generate password prompts looks ok _Email protection in-context signup_ - [x] Visit https://fill.dev/form/registration-email when you're **not** signed into email protection (requires device to be in English locale) - [x] Tap on grey Dax in email field; verify the prompt to sign up for email protection looks ok _Email protection, signed in state_ - [x] Sign into email protection (doesn't matter how you sign in, in-context or normal approach from settings) - [x] Visit https://fill.dev/form/registration-email again, and tap on email field - [x] Verify the prompt to use Email Protection looks ok ### UI changes Screenshots available [here](https://app.asana.com/0/0/1205842983551006/f) for phones and tablets, portrait and landscape
This was referenced Nov 14, 2023
CDRussell
added a commit
that referenced
this pull request
Nov 15, 2023
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) If your PR does not involve UI changes, you can remove the **UI changes** section At a minimum, make sure your changes are tested in API 23 and one of the more recent API levels available. --> Task/Issue URL: https://app.asana.com/0/0/1205495150811754/f We want to apply a max-width constraint to the contents of the autofill dialogs. Some of the autofill dialogs had different ways of constraining content before, and others had none; this PR consolidates them all into using this approach: - Guideline left set to 10% from left edge of dialog, guideline right set to 10% from right edge of dialog - Autofill dialog content can use the remaining 80% of dialog width, up to max of `480dp` ℹ️ Note for reviewing the PR: - a lot of the _changes_ are caused by indentation as views are now inside another view group - tip: hide whitespace differences to see only what's actually changed, ignoring the change indentation <img width="249" alt="Screenshot 2023-10-31 at 12 34 27" src="https://github.com/duckduckgo/Android/assets/1336281/f19f99f0-6b02-4d3a-9810-4d2a4719432c"> _Save login prompt_ - [x] Visit https://fill.dev/form/login-simple and enter username [`abcd`] and password (>= 4 chars) - [x] Verify save prompt looks ok _Select login prompt_ - [x] Visit https://fill.dev/form/login-simple again - [x] verify prompt to login with saved credential looks ok _Update login prompt_ - [x] Visit https://fill.dev/form/login-simple again and dismiss any prompts to use a saved login - [x] Instead, enter same username as before `abcd` and a new password - [x] Verify the update login prompt looks ok _Generate password prompt_ - [x] Visit https://fill.dev/form/registration-email and tap on password field - [x] Verify generate password prompts looks ok _Email protection in-context signup_ - [x] Visit https://fill.dev/form/registration-email when you're **not** signed into email protection (requires device to be in English locale) - [x] Tap on grey Dax in email field; verify the prompt to sign up for email protection looks ok _Email protection, signed in state_ - [x] Sign into email protection (doesn't matter how you sign in, in-context or normal approach from settings) - [x] Visit https://fill.dev/form/registration-email again, and tap on email field - [x] Verify the prompt to use Email Protection looks ok Screenshots available [here](https://app.asana.com/0/0/1205842983551006/f) for phones and tablets, portrait and landscape
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205495150811754/f
Description
We want to apply a max-width constraint to the contents of the autofill dialogs. Some of the autofill dialogs had different ways of constraining content before, and others had none; this PR consolidates them all into using this approach:
480dpℹ️ Note for reviewing the PR:
Steps to test this PR
Save login prompt
abcd] and password (>= 4 chars)Select login prompt
Update login prompt
abcdand a new passwordGenerate password prompt
Email protection in-context signup
Email protection, signed in state
UI changes
Screenshots available here for phones and tablets, portrait and landscape