-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate with remote config to determine if autofill is on by default #3760
Merged
CDRussell
merged 1 commit into
feature/craig/autofill_enabled_by_default
from
feature/craig/autofill_on_by_default_from_remote_config
Nov 10, 2023
Merged
Integrate with remote config to determine if autofill is on by default #3760
CDRussell
merged 1 commit into
feature/craig/autofill_enabled_by_default
from
feature/craig/autofill_on_by_default_from_remote_config
Nov 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 26, 2023
Merged
This was referenced Oct 26, 2023
a25ca79
to
5acb164
Compare
2231905
to
6efe846
Compare
5acb164
to
5bf8a7c
Compare
0b75371
to
41fd748
Compare
5bf8a7c
to
11f6bb9
Compare
14 tasks
41fd748
to
1aae7f9
Compare
0df6107
to
9420837
Compare
CDRussell
commented
Oct 30, 2023
CDRussell
commented
Oct 30, 2023
autofill/autofill-internal/src/main/res/layout/activity_autofill_internal_settings.xml
Show resolved
Hide resolved
9420837
to
e07ac0e
Compare
1aae7f9
to
9367453
Compare
e07ac0e
to
73daeb0
Compare
43c169b
to
41c29de
Compare
73daeb0
to
fc4eba0
Compare
41c29de
to
4e0486e
Compare
6 tasks
4e0486e
to
5cd0f2a
Compare
fc4eba0
to
2f94aa0
Compare
aitorvs
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm and PR test steps work as expected
05a0b02
to
5205cfb
Compare
2f94aa0
to
5991aeb
Compare
8d6f977
to
5354e7f
Compare
5991aeb
to
a74078a
Compare
This was referenced Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205811927559467/f
Description
Integrates with remote config to determine if Autofill should be enabled by default, for new users only.
onByDefault
will be introduced and incrementally rolled outonByDefault
return true but they still won't get it enabled by default)Steps to test this PR
Need to use
play
builds to properly test this, asinternal
builds default to enabled by default.To make tester simpler, would recommend:
PrivacyConfigPersister
. Changeline 63
to beval previousVersion = 0L
to bypass version checks from the downloaded configPrivacyConfigService
as needed for the tests belowWhen remote config new field not yet available
play
build and let it consume production remote configLogins
and verify it is disabled by defaultWhen remote config new field available but not enabled for current user
onByDefault
enabled but rolled out to nobody (example)play
build and let it consume remote configLogins
and verify it is disabled by defaultWhen remote config available to a user on install day
onByDefault
enabled for everybody (example)play
build and let it consume remote configLogins
and verify it is enabled by defaultadb shell am start -a android.settings.DATE_SETTINGS
)Logins
and verify it is still enabled by defaultWhen remote config available to a user but not on install day
onByDefault
enabled but rolled out to nobody (example)play
build and let it consume remote configLogins
and verify it is disabled by defaultadb shell am start -a android.settings.DATE_SETTINGS
)onByDefault
enabled for everybody (example) (might have to do this with a proxy or hardcode JSON if date causes SSL issues). Kill and relaunch app and let it consume remote config.Logins
and verify it is still disabled by default