diff --git a/app/src/androidTest/java/com/duckduckgo/app/browser/BrowserTabViewModelTest.kt b/app/src/androidTest/java/com/duckduckgo/app/browser/BrowserTabViewModelTest.kt index 28b39cc87c37..631746c73d8a 100644 --- a/app/src/androidTest/java/com/duckduckgo/app/browser/BrowserTabViewModelTest.kt +++ b/app/src/androidTest/java/com/duckduckgo/app/browser/BrowserTabViewModelTest.kt @@ -104,7 +104,6 @@ import com.duckduckgo.app.browser.logindetection.NavigationEvent.LoginAttempt import com.duckduckgo.app.browser.model.BasicAuthenticationCredentials import com.duckduckgo.app.browser.model.BasicAuthenticationRequest import com.duckduckgo.app.browser.model.LongPressTarget -import com.duckduckgo.app.browser.newtab.FavoritesQuickAccessAdapter import com.duckduckgo.app.browser.newtab.FavoritesQuickAccessAdapter.QuickAccessFavorite import com.duckduckgo.app.browser.omnibar.ChangeOmnibarPositionFeature import com.duckduckgo.app.browser.omnibar.OmnibarEntryConverter @@ -150,7 +149,6 @@ import com.duckduckgo.app.onboarding.store.AppStage.ESTABLISHED import com.duckduckgo.app.onboarding.store.OnboardingStore import com.duckduckgo.app.onboarding.store.UserStageStore import com.duckduckgo.app.onboarding.ui.page.extendedonboarding.ExtendedOnboardingFeatureToggles -import com.duckduckgo.app.onboarding.ui.page.extendedonboarding.HighlightsOnboardingExperimentManager import com.duckduckgo.app.pixels.AppPixelName import com.duckduckgo.app.pixels.AppPixelName.AUTOCOMPLETE_BANNER_SHOWN import com.duckduckgo.app.pixels.AppPixelName.DUCK_PLAYER_SETTING_ALWAYS_DUCK_PLAYER @@ -492,7 +490,6 @@ class BrowserTabViewModelTest { private val mockUserBrowserProperties: UserBrowserProperties = mock() private val mockAutoCompleteRepository: AutoCompleteRepository = mock() private val changeOmnibarPositionFeature: ChangeOmnibarPositionFeature = mock() - private val mockHighlightsOnboardingExperimentManager: HighlightsOnboardingExperimentManager = mock() private val protectionTogglePlugin = FakePrivacyProtectionTogglePlugin() private val protectionTogglePluginPoint = FakePluginPoint(protectionTogglePlugin) private var fakeAndroidConfigBrowserFeature = FakeFeatureToggleFactory.create(AndroidBrowserConfigFeature::class.java) @@ -528,7 +525,6 @@ class BrowserTabViewModelTest { lazyFaviconManager, ) - whenever(mockHighlightsOnboardingExperimentManager.isHighlightsEnabled()).thenReturn(false) whenever(mockDuckPlayer.observeUserPreferences()).thenReturn(flowOf(UserPreferences(false, Disabled))) whenever(mockDismissedCtaDao.dismissedCtas()).thenReturn(dismissedCtaDaoChannel.consumeAsFlow()) whenever(mockTabRepository.flowTabs).thenReturn(flowOf(emptyList())) @@ -568,7 +564,6 @@ class BrowserTabViewModelTest { extendedOnboardingFeatureToggles = mockExtendedOnboardingFeatureToggles, subscriptions = mock(), duckPlayer = mockDuckPlayer, - highlightsOnboardingExperimentManager = mockHighlightsOnboardingExperimentManager, brokenSitePrompt = mockBrokenSitePrompt, ) @@ -603,7 +598,6 @@ class BrowserTabViewModelTest { whenever(mockPrivacyProtectionsPopupManager.viewState).thenReturn(flowOf(PrivacyProtectionsPopupViewState.Gone)) whenever(mockAppBuildConfig.buildType).thenReturn("debug") whenever(mockDuckPlayer.observeUserPreferences()).thenReturn(flowOf(UserPreferences(false, AlwaysAsk))) - whenever(mockHighlightsOnboardingExperimentManager.isHighlightsEnabled()).thenReturn(false) testee = BrowserTabViewModel( statisticsUpdater = mockStatisticsUpdater, @@ -664,7 +658,6 @@ class BrowserTabViewModelTest { duckChatJSHelper = mockDuckChatJSHelper, refreshPixelSender = refreshPixelSender, changeOmnibarPositionFeature = changeOmnibarPositionFeature, - highlightsOnboardingExperimentManager = mockHighlightsOnboardingExperimentManager, privacyProtectionTogglePlugin = protectionTogglePluginPoint, showOnAppLaunchOptionHandler = mockShowOnAppLaunchHandler, customHeadersProvider = fakeCustomHeadersPlugin, @@ -694,9 +687,9 @@ class BrowserTabViewModelTest { loadUrl("https://duckduckgo.com/?q=test&atb=v117-1&t=ddg_test") testee.onShareSelected() verify(mockCommandObserver, atLeastOnce()).onChanged(commandCaptor.capture()) - assertTrue(commandCaptor.lastValue is Command.ShareLink) + assertTrue(commandCaptor.lastValue is ShareLink) - val shareLink = commandCaptor.lastValue as Command.ShareLink + val shareLink = commandCaptor.lastValue as ShareLink assertEquals("https://duckduckgo.com/?q=test", shareLink.url) } @@ -706,9 +699,9 @@ class BrowserTabViewModelTest { loadUrl(url) testee.onShareSelected() verify(mockCommandObserver, atLeastOnce()).onChanged(commandCaptor.capture()) - assertTrue(commandCaptor.lastValue is Command.ShareLink) + assertTrue(commandCaptor.lastValue is ShareLink) - val shareLink = commandCaptor.lastValue as Command.ShareLink + val shareLink = commandCaptor.lastValue as ShareLink assertEquals(url, shareLink.url) } @@ -1974,7 +1967,7 @@ class BrowserTabViewModelTest { fun whenUserSelectsToShareLinkThenShareLinkCommandSent() { loadUrl("foo.com") testee.onShareSelected() - val command = captureCommands().lastValue as Command.ShareLink + val command = captureCommands().lastValue as ShareLink assertEquals("foo.com", command.url) } @@ -1982,7 +1975,7 @@ class BrowserTabViewModelTest { fun whenUserSelectsToShareLinkWithNullUrlThenShareLinkCommandNotSent() { loadUrl(null) testee.onShareSelected() - assertCommandNotIssued() + assertCommandNotIssued() } @Test @@ -3341,7 +3334,7 @@ class BrowserTabViewModelTest { verify(mockPixel).enqueueFire( AppPixelName.EMAIL_COPIED_TO_CLIPBOARD, - mapOf(Pixel.PixelParameter.COHORT to "cohort", Pixel.PixelParameter.LAST_USED_DAY to "2021-01-01"), + mapOf(PixelParameter.COHORT to "cohort", PixelParameter.LAST_USED_DAY to "2021-01-01"), ) } @@ -3662,7 +3655,7 @@ class BrowserTabViewModelTest { @Test fun whenRemoveFavoriteUndoThenViewStateUpdated() = runTest { val favoriteSite = Favorite(id = UUID.randomUUID().toString(), title = "", url = "www.example.com", position = 0, lastModified = "timestamp") - val quickAccessFavorites = listOf(FavoritesQuickAccessAdapter.QuickAccessFavorite(favoriteSite)) + val quickAccessFavorites = listOf(QuickAccessFavorite(favoriteSite)) whenever(mockSavedSitesRepository.getFavorite("www.example.com")).thenReturn(favoriteSite) favoriteListFlow.send(listOf(favoriteSite)) @@ -4759,7 +4752,7 @@ class BrowserTabViewModelTest { @Test fun whenPageIsChangedWithWebViewErrorResponseThenPrivacyProtectionsPopupManagerIsNotified() = runTest { - testee.onReceivedError(WebViewErrorResponse.BAD_URL, "example2.com") + testee.onReceivedError(BAD_URL, "example2.com") updateUrl( originalUrl = "example.com", @@ -5728,7 +5721,7 @@ class BrowserTabViewModelTest { private suspend fun givenFireButtonPulsing() { whenever(mockExtendedOnboardingFeatureToggles.noBrowserCtas()).thenReturn(mockEnabledToggle) whenever(mockUserStageStore.getUserAppStage()).thenReturn(AppStage.DAX_ONBOARDING) - dismissedCtaDaoChannel.send(listOf(DismissedCta(CtaId.DAX_DIALOG_TRACKERS_FOUND))) + dismissedCtaDaoChannel.send(listOf(DismissedCta(DAX_DIALOG_TRACKERS_FOUND))) } private inline fun assertCommandIssued(instanceAssertions: T.() -> Unit = {}) { diff --git a/app/src/androidTest/java/com/duckduckgo/app/cta/ui/CtaViewModelTest.kt b/app/src/androidTest/java/com/duckduckgo/app/cta/ui/CtaViewModelTest.kt index 93ad1afc823c..dbc90079d67d 100644 --- a/app/src/androidTest/java/com/duckduckgo/app/cta/ui/CtaViewModelTest.kt +++ b/app/src/androidTest/java/com/duckduckgo/app/cta/ui/CtaViewModelTest.kt @@ -34,7 +34,6 @@ import com.duckduckgo.app.onboarding.store.AppStage import com.duckduckgo.app.onboarding.store.OnboardingStore import com.duckduckgo.app.onboarding.store.UserStageStore import com.duckduckgo.app.onboarding.ui.page.extendedonboarding.ExtendedOnboardingFeatureToggles -import com.duckduckgo.app.onboarding.ui.page.extendedonboarding.HighlightsOnboardingExperimentManager import com.duckduckgo.app.pixels.AppPixelName.* import com.duckduckgo.app.privacy.db.UserAllowListRepository import com.duckduckgo.app.privacy.model.HttpsStatus @@ -113,8 +112,6 @@ class CtaViewModelTest { private val mockSubscriptions: Subscriptions = mock() - private val mockHighlightsOnboardingExperimentManager: HighlightsOnboardingExperimentManager = mock() - private val mockBrokenSitePrompt: BrokenSitePrompt = mock() private val requiredDaxOnboardingCtas: List = listOf( @@ -168,7 +165,6 @@ class CtaViewModelTest { extendedOnboardingFeatureToggles = mockExtendedOnboardingFeatureToggles, subscriptions = mockSubscriptions, duckPlayer = mockDuckPlayer, - highlightsOnboardingExperimentManager = mockHighlightsOnboardingExperimentManager, brokenSitePrompt = mockBrokenSitePrompt, ) } @@ -794,28 +790,6 @@ class CtaViewModelTest { assertNull(value) } - @Test - fun givenHighlightsExperimentWhenRefreshCtaOnHomeTabAndIntroCtaWasNotPreviouslyShownThenExperimentIntroCtaShown() = runTest { - givenDaxOnboardingActive() - whenever(mockHighlightsOnboardingExperimentManager.isHighlightsEnabled()).thenReturn(true) - whenever(mockDismissedCtaDao.exists(CtaId.DAX_INTRO)).thenReturn(false) - whenever(mockDismissedCtaDao.exists(CtaId.DAX_DIALOG_SERP)).thenReturn(true) - - val value = testee.refreshCta(coroutineRule.testDispatcher, isBrowserShowing = false) - assertTrue(value is DaxBubbleCta.DaxIntroSearchOptionsCta) - } - - @Test - fun givenHighlightsExperimentWhenGettingFireDialogOnboardingDialogThenReturnExperimentFireDialogCta() = runTest { - givenDaxOnboardingActive() - whenever(mockHighlightsOnboardingExperimentManager.isHighlightsEnabled()).thenReturn(true) - whenever(mockDismissedCtaDao.exists(CtaId.DAX_FIRE_BUTTON)).thenReturn(false) - - val value = testee.getFireDialogCta() - - assertTrue(value is OnboardingDaxDialogCta.DaxFireButtonCta) - } - private suspend fun givenDaxOnboardingActive() { whenever(mockUserStageStore.getUserAppStage()).thenReturn(AppStage.DAX_ONBOARDING) } diff --git a/app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt b/app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt index 76d2b9cc7a55..b0dbedddb725 100644 --- a/app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt +++ b/app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt @@ -223,7 +223,6 @@ import com.duckduckgo.app.global.model.SiteFactory import com.duckduckgo.app.global.model.domain import com.duckduckgo.app.global.model.domainMatchesUrl import com.duckduckgo.app.location.data.LocationPermissionType -import com.duckduckgo.app.onboarding.ui.page.extendedonboarding.HighlightsOnboardingExperimentManager import com.duckduckgo.app.pixels.AppPixelName import com.duckduckgo.app.pixels.AppPixelName.AUTOCOMPLETE_BANNER_DISMISSED import com.duckduckgo.app.pixels.AppPixelName.AUTOCOMPLETE_BANNER_SHOWN @@ -434,7 +433,6 @@ class BrowserTabViewModel @Inject constructor( private val duckChatJSHelper: DuckChatJSHelper, private val refreshPixelSender: RefreshPixelSender, private val changeOmnibarPositionFeature: ChangeOmnibarPositionFeature, - private val highlightsOnboardingExperimentManager: HighlightsOnboardingExperimentManager, private val privacyProtectionTogglePlugin: PluginPoint, private val showOnAppLaunchOptionHandler: ShowOnAppLaunchOptionHandler, private val customHeadersProvider: CustomHeadersProvider, diff --git a/app/src/main/java/com/duckduckgo/app/cta/ui/CtaViewModel.kt b/app/src/main/java/com/duckduckgo/app/cta/ui/CtaViewModel.kt index ce601d580b6c..771f68d718fe 100644 --- a/app/src/main/java/com/duckduckgo/app/cta/ui/CtaViewModel.kt +++ b/app/src/main/java/com/duckduckgo/app/cta/ui/CtaViewModel.kt @@ -35,7 +35,6 @@ import com.duckduckgo.app.onboarding.store.OnboardingStore import com.duckduckgo.app.onboarding.store.UserStageStore import com.duckduckgo.app.onboarding.store.daxOnboardingActive import com.duckduckgo.app.onboarding.ui.page.extendedonboarding.ExtendedOnboardingFeatureToggles -import com.duckduckgo.app.onboarding.ui.page.extendedonboarding.HighlightsOnboardingExperimentManager import com.duckduckgo.app.privacy.db.UserAllowListRepository import com.duckduckgo.app.settings.db.SettingsDataStore import com.duckduckgo.app.statistics.pixels.Pixel @@ -80,7 +79,6 @@ class CtaViewModel @Inject constructor( private val extendedOnboardingFeatureToggles: ExtendedOnboardingFeatureToggles, private val subscriptions: Subscriptions, private val duckPlayer: DuckPlayer, - private val highlightsOnboardingExperimentManager: HighlightsOnboardingExperimentManager, private val brokenSitePrompt: BrokenSitePrompt, ) { @ExperimentalCoroutinesApi @@ -205,22 +203,14 @@ class CtaViewModel @Inject constructor( suspend fun getFireDialogCta(): OnboardingDaxDialogCta? { return withContext(dispatchers.io()) { if (!daxOnboardingActive() || daxDialogFireEducationShown()) return@withContext null - if (highlightsOnboardingExperimentManager.isHighlightsEnabled()) { - return@withContext OnboardingDaxDialogCta.DaxFireButtonCta(onboardingStore, appInstallStore) - } else { - return@withContext OnboardingDaxDialogCta.DaxFireButtonCta(onboardingStore, appInstallStore) - } + OnboardingDaxDialogCta.DaxFireButtonCta(onboardingStore, appInstallStore) } } suspend fun getSiteSuggestionsDialogCta(): OnboardingDaxDialogCta? { return withContext(dispatchers.io()) { if (!daxOnboardingActive() || !canShowDaxIntroVisitSiteCta()) return@withContext null - if (highlightsOnboardingExperimentManager.isHighlightsEnabled()) { - return@withContext OnboardingDaxDialogCta.DaxSiteSuggestionsCta(onboardingStore, appInstallStore) - } else { - return@withContext OnboardingDaxDialogCta.DaxSiteSuggestionsCta(onboardingStore, appInstallStore) - } + OnboardingDaxDialogCta.DaxSiteSuggestionsCta(onboardingStore, appInstallStore) } } @@ -240,38 +230,22 @@ class CtaViewModel @Inject constructor( } canShowDaxIntroCta() && !extendedOnboardingFeatureToggles.noBrowserCtas().isEnabled() -> { - if (highlightsOnboardingExperimentManager.isHighlightsEnabled()) { - DaxBubbleCta.DaxIntroSearchOptionsCta(onboardingStore, appInstallStore) - } else { - DaxBubbleCta.DaxIntroSearchOptionsCta(onboardingStore, appInstallStore) - } + DaxBubbleCta.DaxIntroSearchOptionsCta(onboardingStore, appInstallStore) } canShowDaxIntroVisitSiteCta() && !extendedOnboardingFeatureToggles.noBrowserCtas().isEnabled() -> { - if (highlightsOnboardingExperimentManager.isHighlightsEnabled()) { - DaxBubbleCta.DaxIntroVisitSiteOptionsCta(onboardingStore, appInstallStore) - } else { - DaxBubbleCta.DaxIntroVisitSiteOptionsCta(onboardingStore, appInstallStore) - } + DaxBubbleCta.DaxIntroVisitSiteOptionsCta(onboardingStore, appInstallStore) } canShowDaxCtaEndOfJourney() && !extendedOnboardingFeatureToggles.noBrowserCtas().isEnabled() -> { - if (highlightsOnboardingExperimentManager.isHighlightsEnabled()) { - DaxBubbleCta.DaxEndCta(onboardingStore, appInstallStore) - } else { - DaxBubbleCta.DaxEndCta(onboardingStore, appInstallStore) - } + DaxBubbleCta.DaxEndCta(onboardingStore, appInstallStore) } canShowPrivacyProCta() -> { val titleRes: Int = R.string.onboardingPrivacyProDaxDialogTitle val descriptionRes: Int = R.string.onboardingPrivacyProDaxDialogDescription - if (highlightsOnboardingExperimentManager.isHighlightsEnabled()) { - DaxBubbleCta.DaxPrivacyProCta(onboardingStore, appInstallStore, titleRes, descriptionRes) - } else { - DaxBubbleCta.DaxPrivacyProCta(onboardingStore, appInstallStore, titleRes, descriptionRes) - } + DaxBubbleCta.DaxPrivacyProCta(onboardingStore, appInstallStore, titleRes, descriptionRes) } canShowWidgetCta() -> { @@ -344,64 +318,38 @@ class CtaViewModel @Inject constructor( // Trackers blocked if (!daxDialogTrackersFoundShown() && !isSerpUrl(it.url) && it.orderedTrackerBlockedEntities().isNotEmpty()) { - return if (highlightsOnboardingExperimentManager.isHighlightsEnabled()) { - OnboardingDaxDialogCta.DaxTrackersBlockedCta( - onboardingStore, - appInstallStore, - it.orderedTrackerBlockedEntities(), - settingsDataStore, - ) - } else { - OnboardingDaxDialogCta.DaxTrackersBlockedCta( - onboardingStore, - appInstallStore, - it.orderedTrackerBlockedEntities(), - settingsDataStore, - ) - } + return OnboardingDaxDialogCta.DaxTrackersBlockedCta( + onboardingStore, + appInstallStore, + it.orderedTrackerBlockedEntities(), + settingsDataStore, + ) } // Is major network if (it.entity != null) { it.entity?.let { entity -> - if (!daxDialogNetworkShown() && !daxDialogTrackersFoundShown() && OnboardingDaxDialogCta.mainTrackerNetworks.any { mainNetwork -> - entity.displayName.contains(mainNetwork) - } + if (!daxDialogNetworkShown() && !daxDialogTrackersFoundShown() && + OnboardingDaxDialogCta.mainTrackerNetworks.any { mainNetwork -> entity.displayName.contains(mainNetwork) } ) { - return if (highlightsOnboardingExperimentManager.isHighlightsEnabled()) { - OnboardingDaxDialogCta.DaxMainNetworkCta(onboardingStore, appInstallStore, entity.displayName, host) - } else { - OnboardingDaxDialogCta.DaxMainNetworkCta(onboardingStore, appInstallStore, entity.displayName, host) - } + return OnboardingDaxDialogCta.DaxMainNetworkCta(onboardingStore, appInstallStore, entity.displayName, host) } } } // SERP if (isSerpUrl(it.url) && !daxDialogSerpShown()) { - return if (highlightsOnboardingExperimentManager.isHighlightsEnabled()) { - OnboardingDaxDialogCta.DaxSerpCta(onboardingStore, appInstallStore) - } else { - OnboardingDaxDialogCta.DaxSerpCta(onboardingStore, appInstallStore) - } + return OnboardingDaxDialogCta.DaxSerpCta(onboardingStore, appInstallStore) } // No trackers blocked if (!isSerpUrl(it.url) && !daxDialogOtherShown() && !daxDialogTrackersFoundShown() && !daxDialogNetworkShown()) { - return if (highlightsOnboardingExperimentManager.isHighlightsEnabled()) { - OnboardingDaxDialogCta.DaxNoTrackersCta(onboardingStore, appInstallStore) - } else { - OnboardingDaxDialogCta.DaxNoTrackersCta(onboardingStore, appInstallStore) - } + return OnboardingDaxDialogCta.DaxNoTrackersCta(onboardingStore, appInstallStore) } // End if (canShowDaxCtaEndOfJourney() && daxDialogFireEducationShown()) { - return if (highlightsOnboardingExperimentManager.isHighlightsEnabled()) { - OnboardingDaxDialogCta.DaxEndCta(onboardingStore, appInstallStore) - } else { - OnboardingDaxDialogCta.DaxEndCta(onboardingStore, appInstallStore) - } + return OnboardingDaxDialogCta.DaxEndCta(onboardingStore, appInstallStore) } return null diff --git a/app/src/main/java/com/duckduckgo/app/onboarding/ui/page/extendedonboarding/HighlightsOnboardingExperimentManager.kt b/app/src/main/java/com/duckduckgo/app/onboarding/ui/page/extendedonboarding/HighlightsOnboardingExperimentManager.kt deleted file mode 100644 index d2582617fb19..000000000000 --- a/app/src/main/java/com/duckduckgo/app/onboarding/ui/page/extendedonboarding/HighlightsOnboardingExperimentManager.kt +++ /dev/null @@ -1,48 +0,0 @@ -/* - * Copyright (c) 2024 DuckDuckGo - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package com.duckduckgo.app.onboarding.ui.page.extendedonboarding - -import com.duckduckgo.di.scopes.AppScope -import com.duckduckgo.experiments.api.VariantConfig -import com.duckduckgo.experiments.api.VariantManager -import com.squareup.anvil.annotations.ContributesBinding -import javax.inject.Inject - -interface HighlightsOnboardingExperimentManager { - fun setExperimentVariants() - fun isHighlightsEnabled(): Boolean -} - -@ContributesBinding(AppScope::class) -class HighlightsOnboardingExperimentManagerImpl @Inject constructor( - private val variantManager: VariantManager, -) : HighlightsOnboardingExperimentManager { - - private val isExtendedOnboardingEnabled: Boolean = true - - override fun setExperimentVariants() { - val variants = listOf( - VariantConfig("mw", 0.0, null), // Control variant - VariantConfig("mx", 0.0, null), // Experimental variant - ) - variantManager.updateVariants(variants) - } - - override fun isHighlightsEnabled(): Boolean { - return isExtendedOnboardingEnabled && variantManager.getVariantKey() == "mx" - } -} diff --git a/app/src/test/java/com/duckduckgo/app/cta/ui/OnboardingDaxDialogTests.kt b/app/src/test/java/com/duckduckgo/app/cta/ui/OnboardingDaxDialogTests.kt index d9158046cde5..d43fd7c69fc0 100644 --- a/app/src/test/java/com/duckduckgo/app/cta/ui/OnboardingDaxDialogTests.kt +++ b/app/src/test/java/com/duckduckgo/app/cta/ui/OnboardingDaxDialogTests.kt @@ -28,7 +28,6 @@ import com.duckduckgo.app.onboarding.store.AppStage.DAX_ONBOARDING import com.duckduckgo.app.onboarding.store.OnboardingStore import com.duckduckgo.app.onboarding.store.UserStageStore import com.duckduckgo.app.onboarding.ui.page.extendedonboarding.ExtendedOnboardingFeatureToggles -import com.duckduckgo.app.onboarding.ui.page.extendedonboarding.HighlightsOnboardingExperimentManager import com.duckduckgo.app.privacy.db.UserAllowListRepository import com.duckduckgo.app.settings.db.SettingsDataStore import com.duckduckgo.app.statistics.pixels.Pixel @@ -72,7 +71,6 @@ class OnboardingDaxDialogTests { private val duckDuckGoUrlDetector: DuckDuckGoUrlDetector = mock() private val extendedOnboardingFeatureToggles: ExtendedOnboardingFeatureToggles = mock() private val mockDuckPlayer: DuckPlayer = mock() - private val mockHighlightsOnboardingExperimentManager: HighlightsOnboardingExperimentManager = mock() private val mockBrokenSitePrompt: BrokenSitePrompt = mock() val mockEnabledToggle: Toggle = org.mockito.kotlin.mock { on { it.isEnabled() } doReturn true } @@ -81,7 +79,6 @@ class OnboardingDaxDialogTests { @Before fun before() { whenever(extendedOnboardingFeatureToggles.noBrowserCtas()).thenReturn(mockDisabledToggle) - whenever(mockHighlightsOnboardingExperimentManager.isHighlightsEnabled()).thenReturn(false) testee = CtaViewModel( appInstallStore, @@ -98,7 +95,6 @@ class OnboardingDaxDialogTests { extendedOnboardingFeatureToggles, subscriptions = mock(), mockDuckPlayer, - mockHighlightsOnboardingExperimentManager, mockBrokenSitePrompt, ) }