fixing lint

duckduckgo · Feb 4, 2025 · fc50c76 · fc50c76
1 parent 42f098a
commit fc50c76
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 5 deletions.
diff --git a/...ll/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/service/ViewNodeClassifier.kt b/...ll/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/service/ViewNodeClassifier.kt
@@ -90,7 +90,11 @@ class AutofillServiceViewNodeClassifier @Inject constructor() : ViewNodeClassifi
 
     private fun isTextPasswordField(inputType: Int): Boolean {
         return (inputType and InputType.TYPE_MASK_CLASS) == InputType.TYPE_CLASS_TEXT &&
-            (inputType and InputType.TYPE_MASK_VARIATION) == InputType.TYPE_TEXT_VARIATION_PASSWORD
+            (
+                (inputType and InputType.TYPE_MASK_VARIATION) == InputType.TYPE_TEXT_VARIATION_PASSWORD ||
+                    (inputType and InputType.TYPE_MASK_VARIATION) == InputType.TYPE_TEXT_VARIATION_VISIBLE_PASSWORD ||
+                    (inputType and InputType.TYPE_MASK_VARIATION) == InputType.TYPE_TEXT_VARIATION_WEB_PASSWORD
+                )
     }
 
     private fun getType(autofillHints: Array<String>?): AutofillFieldType {

diff --git a/...ill-impl/src/test/java/com/duckduckgo/autofill/impl/service/AutofillProvideMockBuilder.kt b/...ill-impl/src/test/java/com/duckduckgo/autofill/impl/service/AutofillProvideMockBuilder.kt
@@ -72,6 +72,11 @@ fun viewNode(): ViewNode {
     return mock()
 }
 
+fun ViewNode.inputType(inputType: Int): ViewNode {
+    whenever(this.inputType).thenReturn(inputType)
+    return this
+}
+
 fun ViewNode.webDomain(domain: String): ViewNode {
     whenever(this.webDomain).thenReturn(domain)
     return this

diff --git a/...c/test/java/com/duckduckgo/autofill/impl/service/AutofillServiceViewNodeClassifierTest.kt b/...c/test/java/com/duckduckgo/autofill/impl/service/AutofillServiceViewNodeClassifierTest.kt
@@ -16,6 +16,8 @@
 
 package com.duckduckgo.autofill.impl.service
 
+import android.text.InputType.TYPE_CLASS_TEXT
+import android.text.InputType.TYPE_TEXT_VARIATION_PASSWORD
 import android.util.Pair
 import android.view.View
 import androidx.test.ext.junit.runners.AndroidJUnit4
@@ -85,7 +87,7 @@ class AutofillServiceViewNodeClassifierTest {
             assertEquals(
                 "$usernameCombination failed",
                 USERNAME,
-                testee.classify(viewNode().hint(usernameCombination)),
+                testee.classify(viewNode().inputType(TYPE_CLASS_TEXT).hint(usernameCombination)),
             )
         }
 
@@ -100,7 +102,7 @@ class AutofillServiceViewNodeClassifierTest {
             assertEquals(
                 "$usernameCombination failed",
                 USERNAME,
-                testee.classify(viewNode().idEntry(usernameCombination)),
+                testee.classify(viewNode().inputType(TYPE_CLASS_TEXT).idEntry(usernameCombination)),
             )
         }
 
@@ -116,7 +118,7 @@ class AutofillServiceViewNodeClassifierTest {
             assertEquals(
                 "$passwordCombination failed",
                 PASSWORD,
-                testee.classify(viewNode().hint(passwordCombination)),
+                testee.classify(viewNode().inputType(TYPE_CLASS_TEXT or TYPE_TEXT_VARIATION_PASSWORD).hint(passwordCombination)),
             )
         }
 
@@ -132,7 +134,7 @@ class AutofillServiceViewNodeClassifierTest {
             assertEquals(
                 "$passwordCombination failed",
                 PASSWORD,
-                testee.classify(viewNode().idEntry(passwordCombination)),
+                testee.classify(viewNode().inputType(TYPE_CLASS_TEXT or TYPE_TEXT_VARIATION_PASSWORD).idEntry(passwordCombination)),
             )
         }