added missing tests

duckduckgo · Nov 20, 2023 · f26a7ba · f26a7ba
1 parent bd680db
commit f26a7ba
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 0 deletions.
diff --git a/app/src/androidTest/java/com/duckduckgo/app/browser/BrowserTabViewModelTest.kt b/app/src/androidTest/java/com/duckduckgo/app/browser/BrowserTabViewModelTest.kt
@@ -3801,6 +3801,44 @@ class BrowserTabViewModelTest {
         assertTrue(ctaViewState().favorites == quickAccessFavorites)
     }
 
+    @Test
+    fun whenDeleteBookmarkUndoThenViewStateUpdated() = runTest {
+        val bookmark =
+            Bookmark(id = UUID.randomUUID().toString(), title = "A title", url = "www.example.com", lastModified = "timestamp")
+
+        bookmarksListFlow.send(listOf(bookmark))
+
+        loadUrl(bookmark.url, isBrowserShowing = true)
+
+        testee.onSavedSiteDeleted(bookmark)
+
+        assertTrue(browserViewState().bookmark == null)
+        assertTrue(browserViewState().favorite == null)
+
+        testee.undoDelete(bookmark)
+
+        assertTrue(browserViewState().bookmark == bookmark)
+    }
+
+    @Test
+    fun whenDeleteFavouriteUndoThenViewStateUpdated() = runTest {
+        val favourite =
+            Favorite(id = UUID.randomUUID().toString(), title = "A title", url = "www.example.com", lastModified = "timestamp", 0)
+
+        favoriteListFlow.send(listOf(favourite))
+
+        loadUrl(favourite.url, isBrowserShowing = true)
+
+        testee.onSavedSiteDeleted(favourite)
+
+        assertTrue(browserViewState().bookmark == null)
+        assertTrue(browserViewState().favorite == null)
+
+        testee.undoDelete(favourite)
+
+        assertTrue(browserViewState().favorite == favourite)
+    }
+
     @Test
     fun whenPageChangedThenUpdatePreviousUrlAndUserQueryStateSetToFalse() {
         loadUrl(url = "www.example.com", isBrowserShowing = true)

diff --git a/app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt b/app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt
@@ -2802,6 +2802,7 @@ class BrowserTabViewModel @Inject constructor(
     }
 
     private fun hide(savedSite: SavedSite) {
+        Timber.d("FLOW: hide $savedSite")
         viewModelScope.launch(dispatchers.io()) {
             when (savedSite) {
                 is Bookmark -> {
@@ -2817,20 +2818,23 @@ class BrowserTabViewModel @Inject constructor(
                     hiddenIds.emit(hiddenIds.value.copy(favorites = hiddenIds.value.favorites + savedSite.id))
                 }
             }
+            Timber.d("FLOW: hide ${hiddenIds.value}")
             withContext(dispatchers.main()) {
                 command.value = DeleteSavedSiteConfirmation(savedSite)
             }
         }
     }
 
     fun undoDelete(savedSite: SavedSite) {
+        Timber.d("FLOW: undoDelete $savedSite")
         viewModelScope.launch(dispatchers.io()) {
             hiddenIds.emit(
                 hiddenIds.value.copy(
                     favorites = hiddenIds.value.favorites - savedSite.id,
                     bookmarks = hiddenIds.value.bookmarks - savedSite.id,
                 ),
             )
+            Timber.d("FLOW: hide ${hiddenIds.value}")
         }
     }