ensure autocomplete viewstate is also updated

duckduckgo · Nov 14, 2023 · f1133b2 · f1133b2
1 parent 110b93e
commit f1133b2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/app/src/androidTest/java/com/duckduckgo/app/browser/BrowserTabViewModelTest.kt b/app/src/androidTest/java/com/duckduckgo/app/browser/BrowserTabViewModelTest.kt
@@ -58,6 +58,7 @@ import com.duckduckgo.app.browser.addtohome.AddToHomeCapabilityDetector
 import com.duckduckgo.app.browser.applinks.AppLinksHandler
 import com.duckduckgo.app.browser.favicon.FaviconManager
 import com.duckduckgo.app.browser.favicon.FaviconSource
+import com.duckduckgo.app.browser.favorites.FavoritesQuickAccessAdapter
 import com.duckduckgo.app.browser.favorites.FavoritesQuickAccessAdapter.QuickAccessFavorite
 import com.duckduckgo.app.browser.history.NavigationHistoryEntry
 import com.duckduckgo.app.browser.logindetection.FireproofDialogsEventHandler
@@ -3781,20 +3782,26 @@ class BrowserTabViewModelTest {
     @Test
     fun whenRemoveFavoriteUndoThenViewStateUpdated() = runTest {
         val favoriteSite = Favorite(id = UUID.randomUUID().toString(), title = "", url = "www.example.com", position = 0, lastModified = "timestamp")
+        val quickAccessFavorites = listOf(FavoritesQuickAccessAdapter.QuickAccessFavorite(favoriteSite))
+
         whenever(mockSavedSitesRepository.getFavorite("www.example.com")).thenReturn(favoriteSite)
         favoriteListFlow.send(listOf(favoriteSite))
         loadUrl("www.example.com", isBrowserShowing = true)
         testee.onFavoriteMenuClicked()
 
         assertTrue(browserViewState().favorite == null)
+        assertTrue(autoCompleteViewState().favorites.isEmpty())
+        assertTrue(ctaViewState().favorites.isEmpty())
 
         testee.undoDelete(favoriteSite, 0)
 
         assertTrue(browserViewState().favorite == favoriteSite)
+        assertTrue(autoCompleteViewState().favorites == quickAccessFavorites)
+        assertTrue(ctaViewState().favorites == quickAccessFavorites)
     }
 
     @Test
-    fun whenDeleteFavoriteUndoThenViewStateUpdated() = runTest {
+    fun whenDeleteBookmarkUndoThenViewStateUpdated() = runTest {
         val bookmark =
             Bookmark(id = UUID.randomUUID().toString(), title = "A title", url = "www.example.com", lastModified = "timestamp")
 

diff --git a/app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt b/app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt
@@ -2774,7 +2774,7 @@ class BrowserTabViewModel @Inject constructor(
 
             ctaViewState.value = currentCtaViewState().copy(favorites = quickAccessFavorites)
             browserViewState.value = currentBrowserViewState().copy(favorite = null)
-
+            autoCompleteViewState.value = currentAutoCompleteViewState().copy(favorites = quickAccessFavorites)
             index
         } else {
             browserViewState.value = currentBrowserViewState().copy(bookmark = null, favorite = null)
@@ -2803,6 +2803,7 @@ class BrowserTabViewModel @Inject constructor(
 
                 ctaViewState.value = currentCtaViewState().copy(favorites = quickAccessFavorites)
                 browserViewState.value = currentBrowserViewState().copy(favorite = savedSite)
+                autoCompleteViewState.value = currentAutoCompleteViewState().copy(favorites = quickAccessFavorites)
             }
 
             is Bookmark -> {