cleaning up tests

duckduckgo · Jan 20, 2025 · b1282aa · b1282aa
1 parent 2d66e5a
commit b1282aa
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/...d-sites-impl/src/main/java/com/duckduckgo/savedsites/impl/bookmarks/BookmarksViewModel.kt b/...d-sites-impl/src/main/java/com/duckduckgo/savedsites/impl/bookmarks/BookmarksViewModel.kt
@@ -46,6 +46,7 @@ import com.duckduckgo.savedsites.impl.bookmarks.BookmarksViewModel.Command.Delet
 import com.duckduckgo.savedsites.impl.bookmarks.BookmarksViewModel.Command.ExportedSavedSites
 import com.duckduckgo.savedsites.impl.bookmarks.BookmarksViewModel.Command.ImportedSavedSites
 import com.duckduckgo.savedsites.impl.bookmarks.BookmarksViewModel.Command.LaunchAddFolder
+import com.duckduckgo.savedsites.impl.bookmarks.BookmarksViewModel.Command.LaunchBookmarkExport
 import com.duckduckgo.savedsites.impl.bookmarks.BookmarksViewModel.Command.LaunchBookmarkImport
 import com.duckduckgo.savedsites.impl.bookmarks.BookmarksViewModel.Command.OpenBookmarkFolder
 import com.duckduckgo.savedsites.impl.bookmarks.BookmarksViewModel.Command.OpenSavedSite
@@ -517,7 +518,7 @@ class BookmarksViewModel @Inject constructor(
 
     fun onExportBookmarksClicked() {
         pixel.fire(SavedSitesPixelName.BOOKMARK_MENU_EXPORT_CLICKED)
-        command.value = LaunchBookmarkImport
+        command.value = LaunchBookmarkExport
     }
 
     fun onAddFolderClicked() {

diff --git a/...tes-impl/src/test/java/com/duckduckgo/savedsites/impl/bookmarks/BookmarksViewModelTest.kt b/...tes-impl/src/test/java/com/duckduckgo/savedsites/impl/bookmarks/BookmarksViewModelTest.kt
@@ -33,7 +33,6 @@ import com.duckduckgo.savedsites.api.models.SavedSitesNames
 import com.duckduckgo.savedsites.api.models.SavedSitesNames.BOOKMARKS_ROOT
 import com.duckduckgo.savedsites.api.service.SavedSitesManager
 import com.duckduckgo.savedsites.impl.SavedSitesPixelName
-import com.duckduckgo.savedsites.impl.SavedSitesPixelParameters
 import com.duckduckgo.savedsites.impl.bookmarks.BookmarksAdapter.BookmarkItem
 import com.duckduckgo.savedsites.impl.bookmarks.BookmarksAdapter.BookmarksItemTypes
 import com.duckduckgo.savedsites.impl.store.BookmarksDataStore
@@ -468,20 +467,12 @@ class BookmarksViewModelTest {
     fun whenManualSortingModeSelectedThenDataStored() = runTest {
         testee.onSortingModeSelected(MANUAL)
         verify(bookmarksDataStore).setSortingMode(MANUAL)
-        verify(pixel).fire(
-            SavedSitesPixelName.BOOKMARK_MENU_SORT_MANUAL_CLICKED,
-            parameters = mapOf(SavedSitesPixelParameters.SORT_MODE to MANUAL.name),
-        )
     }
 
     @Test
     fun whenNameSortingModeSelectedThenDataStored() = runTest {
         testee.onSortingModeSelected(NAME)
         verify(bookmarksDataStore).setSortingMode(NAME)
-        verify(pixel).fire(
-            SavedSitesPixelName.BOOKMARK_MENU_SORT_MANUAL_CLICKED,
-            parameters = mapOf(SavedSitesPixelParameters.SORT_MODE to NAME.name),
-        )
     }
 
     @Test