Skip to content

Commit

Permalink
Android ANR: On Oreo (8.1) and below, the app freezes when choosing t…
Browse files Browse the repository at this point in the history
…o submit a Breakage report (#4142)

Task/Issue URL:
https://app.asana.com/0/488551667048375/1206404678635835/f

### Description
Fixed ANR when choosing to submit a breakage report on Oreo and below.

### Steps to test this PR

_Reproduce the issue_
- [ ] Install from `develop` on a device with Android 8.1 or below.
- [ ] Navigate to a website.
- [ ] Open the menu and tap on "Report Broken Site".
- [ ] Notice that nothing happens in the UI and then an ANR is
encountered.

_Test the fix_
- [ ] Install from `this branch` on a device with Android 8.1 or below.
- [ ] Navigate to a website.
- [ ] Open the menu and tap on "Report Broken Site".
- [ ] Notice the `Report Broken Site` screen is displayed and you can
send a report.

### NO UI changes
  • Loading branch information
anikiki authored Feb 1, 2024
1 parent f49d859 commit 5af462f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@
android:layout_height="wrap_content"
android:hint="@string/atp_ReportBreakageCategoriesHint"
app:clickable="true"
android:focusable="true"
android:focusableInTouchMode="true"
app:endIcon="@drawable/ic_chevron_down_24_small"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"/>
Expand Down
2 changes: 2 additions & 0 deletions app/src/main/res/layout/content_broken_sites.xml
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@
android:layout_marginEnd="@dimen/keyline_4"
android:hint="@string/brokenSitesCategoriesHint"
app:clickable="true"
android:focusable="true"
android:focusableInTouchMode="true"
app:endIcon="@drawable/ic_chevron_down_24_small"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
Expand Down

0 comments on commit 5af462f

Please sign in to comment.