From 364cfab79d0ac03bc11fbcd655d89cc378b2a77f Mon Sep 17 00:00:00 2001 From: Cris Barreiro Date: Mon, 3 Feb 2025 18:23:59 +0100 Subject: [PATCH] Fix globe icon --- .../app/browser/omnibar/OmnibarLayoutViewModel.kt | 1 + .../app/browser/omnibar/OmnibarLayoutViewModelTest.kt | 10 ++++++++++ 2 files changed, 11 insertions(+) diff --git a/app/src/main/java/com/duckduckgo/app/browser/omnibar/OmnibarLayoutViewModel.kt b/app/src/main/java/com/duckduckgo/app/browser/omnibar/OmnibarLayoutViewModel.kt index 4e7c7f5ea05f..d10cd14badf9 100644 --- a/app/src/main/java/com/duckduckgo/app/browser/omnibar/OmnibarLayoutViewModel.kt +++ b/app/src/main/java/com/duckduckgo/app/browser/omnibar/OmnibarLayoutViewModel.kt @@ -310,6 +310,7 @@ class OmnibarLayoutViewModel @Inject constructor( _viewState.update { it.copy( + viewMode = viewMode, leadingIconState = leadingIcon, scrollingEnabled = scrollingEnabled, showVoiceSearch = shouldShowVoiceSearch( diff --git a/app/src/test/java/com/duckduckgo/app/browser/omnibar/OmnibarLayoutViewModelTest.kt b/app/src/test/java/com/duckduckgo/app/browser/omnibar/OmnibarLayoutViewModelTest.kt index 9bfc352d5e1c..c6333f91ba1c 100644 --- a/app/src/test/java/com/duckduckgo/app/browser/omnibar/OmnibarLayoutViewModelTest.kt +++ b/app/src/test/java/com/duckduckgo/app/browser/omnibar/OmnibarLayoutViewModelTest.kt @@ -287,6 +287,7 @@ class OmnibarLayoutViewModelTest { val viewState = awaitItem() assertTrue(viewState.leadingIconState == LeadingIconState.GLOBE) assertTrue(viewState.scrollingEnabled) + assertTrue(viewState.viewMode is ViewMode.Error) } } @@ -298,6 +299,7 @@ class OmnibarLayoutViewModelTest { val viewState = awaitItem() assertTrue(viewState.leadingIconState == LeadingIconState.GLOBE) assertTrue(viewState.scrollingEnabled) + assertTrue(viewState.viewMode is ViewMode.SSLWarning) } } @@ -309,6 +311,7 @@ class OmnibarLayoutViewModelTest { val viewState = awaitItem() assertTrue(viewState.leadingIconState == LeadingIconState.GLOBE) assertTrue(viewState.scrollingEnabled) + assertTrue(viewState.viewMode is ViewMode.MaliciousSiteWarning) } } @@ -320,6 +323,7 @@ class OmnibarLayoutViewModelTest { val viewState = awaitItem() assertTrue(viewState.leadingIconState == LeadingIconState.SEARCH) assertFalse(viewState.scrollingEnabled) + assertTrue(viewState.viewMode is ViewMode.NewTab) } } @@ -331,6 +335,7 @@ class OmnibarLayoutViewModelTest { val viewState = awaitItem() assertTrue(viewState.leadingIconState == LeadingIconState.SEARCH) assertTrue(viewState.scrollingEnabled) + assertTrue(viewState.viewMode is ViewMode.Browser) } } @@ -342,6 +347,7 @@ class OmnibarLayoutViewModelTest { testee.viewState.test { val viewState = expectMostRecentItem() assertTrue(viewState.leadingIconState == LeadingIconState.SEARCH) + assertTrue(viewState.viewMode is ViewMode.Error) } } @@ -353,6 +359,7 @@ class OmnibarLayoutViewModelTest { testee.viewState.test { val viewState = expectMostRecentItem() assertTrue(viewState.leadingIconState == LeadingIconState.SEARCH) + assertTrue(viewState.viewMode is ViewMode.SSLWarning) } } @@ -364,6 +371,7 @@ class OmnibarLayoutViewModelTest { testee.viewState.test { val viewState = expectMostRecentItem() assertTrue(viewState.leadingIconState == LeadingIconState.SEARCH) + assertTrue(viewState.viewMode is ViewMode.MaliciousSiteWarning) } } @@ -375,6 +383,7 @@ class OmnibarLayoutViewModelTest { testee.viewState.test { val viewState = expectMostRecentItem() assertTrue(viewState.leadingIconState == LeadingIconState.SEARCH) + assertTrue(viewState.viewMode is ViewMode.NewTab) } } @@ -386,6 +395,7 @@ class OmnibarLayoutViewModelTest { testee.viewState.test { val viewState = awaitItem() assertTrue(viewState.leadingIconState == LeadingIconState.SEARCH) + assertTrue(viewState.viewMode is ViewMode.Browser) } }