-
Notifications
You must be signed in to change notification settings - Fork 935
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Integrate with remote config to determine if autofill is on by default
- Loading branch information
Showing
14 changed files
with
504 additions
and
182 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70 changes: 70 additions & 0 deletions
70
...l/autofill-impl/src/test/java/com/duckduckgo/autofill/store/RealAutofillPrefsStoreTest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| package com.duckduckgo.autofill.store | ||
|
|
||
| import androidx.test.ext.junit.runners.AndroidJUnit4 | ||
| import androidx.test.platform.app.InstrumentationRegistry | ||
| import com.duckduckgo.autofill.store.feature.AutofillDefaultStateDecider | ||
| import org.junit.Assert.assertFalse | ||
| import org.junit.Assert.assertTrue | ||
| import org.junit.Test | ||
| import org.junit.runner.RunWith | ||
| import org.mockito.kotlin.mock | ||
| import org.mockito.kotlin.never | ||
| import org.mockito.kotlin.times | ||
| import org.mockito.kotlin.verify | ||
| import org.mockito.kotlin.verifyNoMoreInteractions | ||
| import org.mockito.kotlin.whenever | ||
|
|
||
| @RunWith(AndroidJUnit4::class) | ||
| class RealAutofillPrefsStoreTest { | ||
|
|
||
| private val context = InstrumentationRegistry.getInstrumentation().targetContext | ||
| private val defaultStateDecider: AutofillDefaultStateDecider = mock() | ||
|
|
||
| private val testee = RealAutofillPrefsStore( | ||
| applicationContext = context, | ||
| defaultStateDecider = defaultStateDecider, | ||
| ) | ||
|
|
||
| @Test | ||
| fun whenAutofillStateNeverSetManuallyThenDefaultStateDeciderUsed() { | ||
| testee.isEnabled | ||
| verify(defaultStateDecider).defaultState() | ||
| } | ||
|
|
||
| @Test | ||
| fun whenAutofillStateWasManuallySetToEnabledThenDefaultStateDeciderNotUsed() { | ||
| testee.isEnabled = true | ||
| testee.isEnabled | ||
| verify(defaultStateDecider, never()).defaultState() | ||
| } | ||
|
|
||
| @Test | ||
| fun whenAutofillStateWasManuallySetToDisabledThenDefaultStateDeciderNotUsed() { | ||
| testee.isEnabled = false | ||
| testee.isEnabled | ||
| verify(defaultStateDecider, never()).defaultState() | ||
| } | ||
|
|
||
| @Test | ||
| fun whenDeterminedEnabledByDefaultOnceThenNotDecidedAgain() { | ||
| // first call will decide default state should be enabled | ||
| whenever(defaultStateDecider.defaultState()).thenReturn(true) | ||
| assertTrue(testee.isEnabled) | ||
| verify(defaultStateDecider).defaultState() | ||
|
|
||
| // second call should not invoke decider again | ||
| assertTrue(testee.isEnabled) | ||
| verifyNoMoreInteractions(defaultStateDecider) | ||
| } | ||
|
|
||
| @Test | ||
| fun whenDeterminedNotEnabledByDefaultOnceThenWillCallToDeciderAgain() { | ||
| // first call will decide default state should not be enabled | ||
| whenever(defaultStateDecider.defaultState()).thenReturn(false) | ||
| assertFalse(testee.isEnabled) | ||
|
|
||
| // second call should invoke decider again | ||
| assertFalse(testee.isEnabled) | ||
| verify(defaultStateDecider, times(2)).defaultState() | ||
| } | ||
| } |
70 changes: 70 additions & 0 deletions
70
...rc/test/java/com/duckduckgo/autofill/store/feature/RealAutofillDefaultStateDeciderTest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| package com.duckduckgo.autofill.store.feature | ||
|
|
||
| import com.duckduckgo.autofill.api.InternalTestUserChecker | ||
| import com.duckduckgo.browser.api.UserBrowserProperties | ||
| import com.duckduckgo.feature.toggles.api.toggle.AutofillTestFeature | ||
| import org.junit.Assert.* | ||
| import org.junit.Test | ||
| import org.mockito.kotlin.mock | ||
| import org.mockito.kotlin.whenever | ||
|
|
||
| class RealAutofillDefaultStateDeciderTest { | ||
|
|
||
| private val userBrowserProperties: UserBrowserProperties = mock() | ||
| private val autofillFeature = AutofillTestFeature() | ||
| private val internalTestUserChecker: InternalTestUserChecker = mock() | ||
| private val testee = RealAutofillDefaultStateDecider( | ||
| userBrowserProperties = userBrowserProperties, | ||
| autofillFeature = autofillFeature, | ||
| internalTestUserChecker = internalTestUserChecker, | ||
| ) | ||
|
|
||
| @Test | ||
| fun whenRemoteFeatureDisabledThenNumberOfDaysInstalledIsIrrelevant() { | ||
| configureRemoteFeatureEnabled(false) | ||
|
|
||
| configureDaysInstalled(0) | ||
| assertFalse(testee.defaultState()) | ||
|
|
||
| configureDaysInstalled(1000) | ||
| assertFalse(testee.defaultState()) | ||
| } | ||
|
|
||
| @Test | ||
| fun whenNumberOfDaysInstalledIsNotZeroThenFeatureFlagIsIrrelevant() { | ||
| configureDaysInstalled(0) | ||
|
|
||
| configureRemoteFeatureEnabled(false) | ||
| assertFalse(testee.defaultState()) | ||
|
|
||
| configureRemoteFeatureEnabled(false) | ||
| assertFalse(testee.defaultState()) | ||
| } | ||
|
|
||
| @Test | ||
| fun whenInternalTesterThenAlwaysEnabledByDefault() { | ||
| configureDaysInstalled(100) | ||
| configureRemoteFeatureEnabled(false) | ||
| configureAsInternalTester() | ||
| assertTrue(testee.defaultState()) | ||
| } | ||
|
|
||
| @Test | ||
| fun whenInstalledSameDayAndFeatureFlagEnabledThenEnabledByDefault() { | ||
| configureDaysInstalled(0) | ||
| configureRemoteFeatureEnabled(true) | ||
| assertTrue(testee.defaultState()) | ||
| } | ||
|
|
||
| private fun configureAsInternalTester() { | ||
| whenever(internalTestUserChecker.isInternalTestUser).thenReturn(true) | ||
| } | ||
|
|
||
| private fun configureRemoteFeatureEnabled(enabled: Boolean) { | ||
| autofillFeature.onByDefault = enabled | ||
| } | ||
|
|
||
| private fun configureDaysInstalled(daysInstalled: Long) { | ||
| whenever(userBrowserProperties.daysSinceInstalled()).thenReturn(daysInstalled) | ||
| } | ||
| } |
42 changes: 42 additions & 0 deletions
42
...ofill-impl/src/test/java/com/duckduckgo/feature/toggles/api/toggle/AutofillTestFeature.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| /* | ||
| * Copyright (c) 2023 DuckDuckGo | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.duckduckgo.feature.toggles.api.toggle | ||
|
|
||
| import com.duckduckgo.autofill.api.AutofillFeature | ||
| import com.duckduckgo.feature.toggles.api.Toggle | ||
|
|
||
| class AutofillTestFeature : AutofillFeature { | ||
| var topLevelFeatureEnabled: Boolean = false | ||
| var canInjectCredentials: Boolean = false | ||
| var canSaveCredentials: Boolean = false | ||
| var canGeneratePassword: Boolean = false | ||
| var canAccessCredentialManagement: Boolean = false | ||
| var onByDefault: Boolean = false | ||
|
|
||
| override fun self(): Toggle = TestToggle(topLevelFeatureEnabled) | ||
| override fun canInjectCredentials(): Toggle = TestToggle(canInjectCredentials) | ||
| override fun canSaveCredentials(): Toggle = TestToggle(canSaveCredentials) | ||
| override fun canGeneratePasswords(): Toggle = TestToggle(canGeneratePassword) | ||
| override fun canAccessCredentialManagement(): Toggle = TestToggle(canAccessCredentialManagement) | ||
| override fun onByDefault(): Toggle = TestToggle(onByDefault) | ||
| } | ||
|
|
||
| open class TestToggle(val enabled: Boolean) : Toggle { | ||
| override fun getRawStoredState(): Toggle.State? = null | ||
| override fun setEnabled(state: Toggle.State) {} | ||
| override fun isEnabled(): Boolean = enabled | ||
| } |
Oops, something went wrong.