ok actually compute cardinalities bottom up

duckdb · Oct 22, 2024 · 57617f3 · 57617f3
1 parent 07d1348
commit 57617f3
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/src/hnsw/hnsw_optimize_join.cpp b/src/hnsw/hnsw_optimize_join.cpp
@@ -335,9 +335,15 @@ HNSWIndexJoinOptimizer::HNSWIndexJoinOptimizer() {
 
 class CardinalityResetter final : public LogicalOperatorVisitor {
 public:
+	ClientContext &context;
+
+	explicit CardinalityResetter(ClientContext &context_p) : context(context_p) {
+	}
+
 	void VisitOperator(LogicalOperator &op) override {
 		op.has_estimated_cardinality = false;
 		VisitOperatorChildren(op);
+		op.EstimateCardinality(context);
 	}
 };
 
@@ -675,6 +681,9 @@ bool HNSWIndexJoinOptimizer::TryOptimize(Binder &binder, ClientContext &context,
 	// Swap the plan
 	plan = std::move(new_projection);
 
+	CardinalityResetter cardinality_resetter(context);
+	cardinality_resetter.VisitOperator(*root);
+
 	return true;
 }