fix crash on finalization for logical_type from get_value_type #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 1, 2025
jraymakers
deleted the
jray/fix-crash-on-finalization-for-logical-type-from-get-value-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a crash caused by destroying the
logical_typereturned byget_value_typein the finalizer for the returned External. Apparently, unlike all otherlogical_types returned by the C API, this one must not be explicitly destroyed; it's tied to the lifetime of the value.This was the cause of the frequent but inconsistent failures in the bindings tests for Windows. Probably it was only happening on Windows and not the other platforms due to timing differences. I re-enabled the Windows tests.