Skip to content

Commit

Permalink
Merge pull request #61 from duckdb/jray/update-deps
Browse files Browse the repository at this point in the history
update deps
  • Loading branch information
jraymakers authored Dec 12, 2024
2 parents 38c9273 + 41229cc commit cd45139
Show file tree
Hide file tree
Showing 5 changed files with 230 additions and 219 deletions.
6 changes: 3 additions & 3 deletions api/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
"@duckdb/node-bindings": "workspace:*"
},
"devDependencies": {
"@types/node": "^20.17.5",
"@types/node": "^20.17.10",
"rimraf": "^6.0.1",
"typescript": "^5.6.3",
"vitest": "^2.1.4"
"typescript": "^5.7.2",
"vitest": "^2.1.8"
}
}
2 changes: 1 addition & 1 deletion api/src/DuckDBVector.ts
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ function getStringBytes(dataView: DataView, offset: number): Uint8Array {
if (lengthInBytes <= 12) {
return new Uint8Array(dataView.buffer, dataView.byteOffset + offset + 4, lengthInBytes);
} else {
return duckdb.get_data_from_pointer(dataView.buffer, dataView.byteOffset + offset + 8, lengthInBytes);
return duckdb.get_data_from_pointer(dataView.buffer as ArrayBuffer, dataView.byteOffset + offset + 8, lengthInBytes);
}
}

Expand Down
8 changes: 4 additions & 4 deletions bindings/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@
},
"dependencies": {
"@duckdb/node-bindings": "workspace:*",
"node-addon-api": "^8.2.1",
"node-gyp": "^10.2.0",
"node-addon-api": "^8.3.0",
"node-gyp": "^10.3.1",
"rimraf": "^5.0.10",
"typescript": "^5.6.3",
"vitest": "^2.1.4"
"typescript": "^5.7.2",
"vitest": "^2.1.8"
}
}
2 changes: 1 addition & 1 deletion bindings/test/utils/getValue.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ function getStringBytes(dv: DataView, offset: number): Uint8Array {
if (lengthInBytes <= 12) {
return new Uint8Array(dv.buffer, dv.byteOffset + offset + 4, lengthInBytes);
} else {
return duckdb.get_data_from_pointer(dv.buffer, dv.byteOffset + offset + 8, lengthInBytes);
return duckdb.get_data_from_pointer(dv.buffer as ArrayBuffer, dv.byteOffset + offset + 8, lengthInBytes);
}
}

Expand Down
Loading

0 comments on commit cd45139

Please sign in to comment.