Skip to content

Commit

Permalink
linux workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
jraymakers committed Jun 19, 2024
1 parent d187454 commit c6a389a
Showing 1 changed file with 20 additions and 11 deletions.
31 changes: 20 additions & 11 deletions .github/workflows/NodeJS.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,19 +32,20 @@ jobs:
# DUCKDB_NODE_BUILD_CACHE: 0 # create a standalone package
# NODE_AUTH_TOKEN: ${{secrets.NODE_AUTH_TOKEN}}

# linux-nodejs:
# name: node.js Linux
# runs-on: ubuntu-20.04
linux-nodejs:
name: node.js Linux
runs-on: ubuntu-latest
# needs: set-up-npm
# continue-on-error: ${{ matrix.node != '18' && matrix.node != '20' && matrix.node != '21' }}
# env:
# TARGET_ARCH: ${{ matrix.target_arch }}
env:
TARGET_ARCH: ${{ matrix.target_arch }}
# DUCKDB_NODE_BUILD_CACHE: 0
# strategy:
# matrix:
strategy:
matrix:
# node.js current support policy to be found at https://github.com/duckdb/duckdb-node/tree/main/#Supported-Node-versions
# node: [ '12', '14', '16', '17', '18', '19', '20', '21']
# target_arch: [ x64, arm64 ]
node: ['20']
target_arch: [ x64, arm64 ]
# isRelease:
# - ${{ startsWith(github.ref, 'refs/tags/v') || github.ref == 'refs/heads/main' }}
# exclude:
Expand All @@ -68,11 +69,18 @@ jobs:
# node: 21
# target_arch: arm64

# steps:
# - uses: actions/checkout@v3
steps:
- name: Checkout code
uses: actions/checkout@v3
# with:
# fetch-depth: 0

- name: Install Python dependencies
run: pip install pycparser

- name: Install NPM dependencies & build Node bindings
run: npm i

# - name: Update apt
# shell: bash
# run: |
Expand Down Expand Up @@ -106,7 +114,8 @@ jobs:
# run: ./scripts/node_build.sh ${{ matrix.node }}

osx-nodejs:
if: startsWith(github.ref, 'refs/tags/v') || github.ref == 'refs/heads/main' || github.repository != 'duckdb/duckdb-node'
if: false # temporarily disable while working on Linux workflow
# if: startsWith(github.ref, 'refs/tags/v') || github.ref == 'refs/heads/main' || github.repository != 'duckdb/duckdb-node'
name: node.js OSX
runs-on: macos-latest
# needs: linux-nodejs
Expand Down

0 comments on commit c6a389a

Please sign in to comment.