Merge pull request #63 from duckdb/jray/rename-libduckdb-fetching-files

rename libduckdb fetching files to be architecture-specific
duckdb · Dec 15, 2024 · 0325c80 · 0325c80
2 parents 8f21499 + b3cb7ae
commit 0325c80
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -52,9 +52,9 @@ Change version in:
 ### Upgrade DuckDB Version
 
 Change version in:
-- `bindings/scripts/fetch_libduckdb_linux.py`
-- `bindings/scripts/fetch_libduckdb_mac.py`
-- `bindings/scripts/fetch_libduckdb_win.py`
+- `bindings/scripts/fetch_libduckdb_linux_amd64.py`
+- `bindings/scripts/fetch_libduckdb_osx_universal.py`
+- `bindings/scripts/fetch_libduckdb_windows_amd64.py`
 - `bindings/test/constants.test.ts`
 
 Also change DuckDB version in package versions.

diff --git a/bindings/binding.gyp b/bindings/binding.gyp
@@ -6,17 +6,17 @@
       'conditions': [
         ['OS=="linux"', {
           'variables': {
-            'script_path': '<(module_root_dir)/scripts/fetch_libduckdb_linux.py',
+            'script_path': '<(module_root_dir)/scripts/fetch_libduckdb_linux_amd64.py',
           },
         }],
         ['OS=="mac"', {
           'variables': {
-            'script_path': '<(module_root_dir)/scripts/fetch_libduckdb_mac.py',
+            'script_path': '<(module_root_dir)/scripts/fetch_libduckdb_osx_universal.py',
           },
         }],
         ['OS=="win"', {
           'variables': {
-            'script_path': '<(module_root_dir)/scripts/fetch_libduckdb_win.py',
+            'script_path': '<(module_root_dir)/scripts/fetch_libduckdb_windows_amd64.py',
           },
         }],
       ],

diff --git a/bindings/scripts/fetch_libduckdb_linux.py → ...gs/scripts/fetch_libduckdb_linux_amd64.py b/bindings/scripts/fetch_libduckdb_linux.py → ...gs/scripts/fetch_libduckdb_linux_amd64.py
diff --git a/bindings/scripts/fetch_libduckdb_mac.py → .../scripts/fetch_libduckdb_osx_universal.py b/bindings/scripts/fetch_libduckdb_mac.py → .../scripts/fetch_libduckdb_osx_universal.py
diff --git a/bindings/scripts/fetch_libduckdb_win.py → .../scripts/fetch_libduckdb_windows_amd64.py b/bindings/scripts/fetch_libduckdb_win.py → .../scripts/fetch_libduckdb_windows_amd64.py