-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic differentiation for primitives #311
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## v1.4.2 #311 +/- ##
==========================================
+ Coverage 97.37% 97.40% +0.03%
==========================================
Files 206 208 +2
Lines 23048 23451 +403
==========================================
+ Hits 22443 22843 +400
- Misses 605 608 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
from a quick scroll this looks (a) awesome and (b) like it doesn't change any of the public API, so suitable for a patch release? if so, I'll push a blank v1.4.2 branch and it can target that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it. left a few comments – nothing major
@t-young31 Thank you! Yes, the modification should not change the public api, so it should be ok for patch release. |
have changed the base to v1.4.2. would you mind adding something to the changelog? cheers 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feel free to merge after the changelog update 🚀
@t-young31 Could you please have one last check before merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Replaces hand-coded derivatives for primitive internals with automatic differentiation so that upto second derivatives can be calculated for any primitive.
Checklist