Delegate addition in DialogManager and LaunchGate + StringHandler for Localization #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charvoa
commented
Sep 4, 2018
charvoa
commented
- We added a Delegate in DialogManager in order to know when the "dismiss" button is called.
- We added a Delegate in LaunchGate in order to know if the app needs update or no.
- We added a StringHandler, which is a struct that contains the strings displayed in the popup. Why ? Because, at the moment, we are handling Localization on the client side, and not on the back-end side. So we need to be able to provide strings to display in order to display them instead of the text that's in the JSON.
houndci-bot
reviewed
Sep 5, 2018
Source/LaunchGate.swift
Outdated
| } | ||
| - Returns: A `LaunchGate` instance or `nil` | ||
| */ | ||
| public init?(configURI: String, appStoreURI: String, stringHandler: StringHandler? = nil, dialogDelegate: DialogManagerDelegate? = nil) { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 141 characters (line_length)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.