Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LoRaEMU and LoRa ECLA. #5

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Added LoRaEMU and LoRa ECLA. #5

wants to merge 5 commits into from

Conversation

BigJk
Copy link

@BigJk BigJk commented Jun 9, 2023

I've added

  • Steps to build LoRaEMU and LoRa ECLA in builders
  • Moving all relevant files to the final container
  • Added the scenario runner and 3 example scenarios
  • Added info in readme about the simulator usage

Copy link
Member

@gh0st42 gh0st42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make it international and pin the loreemu version

thank you!


# == build loraemu + frontend and move files to /usr/local/bin

RUN git clone https://github.com/bigjk/loraemu.git $GOPATH/src/github.com/bigjk/loraemu && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version tag or commit ID should be pinned here

},
"nodes": [
{
"id": "auto1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe auto could be car?

"icon": "tower-broadcast"
},
{
"id": "nord1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

north

"icon": "tower-broadcast"
},
{
"id": "süd1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

south

"icon": "tower-broadcast"
},
{
"id": "fußgänger1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make the node names international :)

@BigJk
Copy link
Author

BigJk commented Jun 22, 2023

  • Pinned the LoRaEMU version
  • Replaced all names with common english equivalents (auto -> car, fußgänger -> person, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants