Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redact sensitive data on sockets #9

Closed
dsienkiewicz opened this issue Apr 24, 2023 · 0 comments · Fixed by #17
Closed

Redact sensitive data on sockets #9

dsienkiewicz opened this issue Apr 24, 2023 · 0 comments · Fixed by #17
Labels
enhancement New feature or request
Milestone
0.2

Comments

@dsienkiewicz
Copy link
Owner

Problem
We need to move out of removing user & password fields from socket's state.
Sockets should have all information needed to perform process restart.

Solution
Add inspect implementation to sockets, so when printed, both user & password information are redacted, but preserved within the process' state.
@dsienkiewicz dsienkiewicz added the enhancement New feature or request label Apr 24, 2023
@dsienkiewicz dsienkiewicz added this to the 0.2 milestone Apr 24, 2023
@dsienkiewicz dsienkiewicz mentioned this issue Dec 5, 2023
Merged
@dsienkiewicz dsienkiewicz linked a pull request Dec 5, 2023 that will close this issue
#9 Redact state of MainSocket from sensitive info #17
Merged
dsienkiewicz added a commit that referenced this issue Dec 5, 2023
@dsienkiewicz
Merge pull request #17 from dsienkiewicz/9-redact-sensitive-data-on-s…
f5e4754 
…ockets

#9 Redact state of MainSocket from sensitive info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.2
Development

Successfully merging a pull request may close this issue.

#9 Redact state of MainSocket from sensitive info dsienkiewicz/xtb_client_ex
1 participant
@dsienkiewicz