Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't guard string fields in JSON responses #12

Closed
dsienkiewicz opened this issue May 19, 2023 · 0 comments · Fixed by #15
Closed

Don't guard string fields in JSON responses #12

dsienkiewicz opened this issue May 19, 2023 · 0 comments · Fixed by #15
Assignees
@dsienkiewicz
Labels
bug Something isn't working
Milestone
0.2

Comments

@dsienkiewicz
Copy link
Owner

Problem
In most messages, on new/1 functions, there're guards for binary fields. Those should be removed, as sometimes such fields come as NULLs, not empty strings.

Solution
In all messages' new/1 functions:

  • remove guards for binary fields
  • add field_value || "" to default to empty string.
@dsienkiewicz dsienkiewicz added the bug Something isn't working label May 19, 2023
@dsienkiewicz dsienkiewicz added this to the 0.2 milestone May 19, 2023
@dsienkiewicz dsienkiewicz self-assigned this Nov 21, 2023
@dsienkiewicz dsienkiewicz linked a pull request Nov 23, 2023 that will close this issue
#12 Dont guard string fields in json responses #15
Merged
dsienkiewicz added a commit that referenced this issue Dec 5, 2023
@dsienkiewicz
Merge pull request #15 from dsienkiewicz/12-dont-guard-string-fields-…
4f19351 
…in-json-responses

#12 Dont guard string fields in json responses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsienkiewicz dsienkiewicz

Labels
bug Something isn't working
Projects
None yet
Milestone
0.2
Development

Successfully merging a pull request may close this issue.

#12 Dont guard string fields in json responses dsienkiewicz/xtb_client_ex
1 participant
@dsienkiewicz