chore: more explicit types

dsherret · Dec 22, 2023 · 5ff1b02 · 5ff1b02
1 parent 59ff85f
commit 5ff1b02
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/src/command.ts b/src/command.ts
@@ -71,7 +71,7 @@ const builtInCommands = {
 };
 
 /** @internal */
-export const getRegisteredCommandNamesSymbol = Symbol();
+export const getRegisteredCommandNamesSymbol: unique symbol = Symbol();
 
 /**
  * Underlying builder API for executing commands.
@@ -483,7 +483,7 @@ export class CommandBuilder implements PromiseLike<CommandResult> {
   }
 
   /** @internal */
-  [getRegisteredCommandNamesSymbol]() {
+  [getRegisteredCommandNamesSymbol](): string[] {
     return Object.keys(this.#state.commands);
   }
 }

diff --git a/src/path.ts b/src/path.ts
@@ -84,13 +84,13 @@ export class PathRef {
   }
 
   /** @internal */
-  static [Symbol.hasInstance](instance: any) {
+  static [Symbol.hasInstance](instance: any): boolean {
     // this should never change because it should work accross versions
     return instance?.constructor?.instanceofSymbol === PathRef.instanceofSymbol;
   }
 
   /** @internal */
-  [Symbol.for("Deno.customInspect")]() {
+  [Symbol.for("Deno.customInspect")](): string {
     return `PathRef("${this.#path}")`;
   }
 

diff --git a/src/pipes.ts b/src/pipes.ts
@@ -123,7 +123,7 @@ export class PipedBuffer implements WriterSync {
     this.#inner = new Buffer();
   }
 
-  getBuffer() {
+  getBuffer(): Buffer | undefined {
     if (this.#inner instanceof Buffer) {
       return this.#inner;
     } else {
@@ -143,7 +143,7 @@ export class PipedBuffer implements WriterSync {
     }
   }
 
-  writeSync(p: Uint8Array) {
+  writeSync(p: Uint8Array): number {
     return this.#inner.writeSync(p);
   }
 

diff --git a/src/request.ts b/src/request.ts
@@ -21,7 +21,7 @@ interface RequestBuilderState {
 }
 
 /** @internal */
-export const withProgressBarFactorySymbol = Symbol();
+export const withProgressBarFactorySymbol: unique symbol = Symbol();
 
 /**
  * Builder API for downloading files.
@@ -197,7 +197,7 @@ export class RequestBuilder implements PromiseLike<RequestResult> {
   }
 
   /** @internal */
-  [withProgressBarFactorySymbol](factory: (message: string) => ProgressBar) {
+  [withProgressBarFactorySymbol](factory: (message: string) => ProgressBar): RequestBuilder {
     return this.#newWithState((state) => {
       state.progressBarFactory = factory;
     });