Skip to content

Commit

Permalink
reduce complexity about checking mandatory fields
Browse files Browse the repository at this point in the history
  • Loading branch information
Daniel Seichter committed Jul 27, 2024
1 parent 9655a0b commit 76e9a88
Showing 1 changed file with 4 additions and 16 deletions.
20 changes: 4 additions & 16 deletions src/validate_workflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,22 +69,10 @@ def return_fielderror(fieldname):
def start_validation(payload, iscli=True):
logger.debug(payload)

if "key1" not in payload:
return return_fielderror("key1")
if "key2" not in payload:
return return_fielderror("key2")
if "ownvat" not in payload:
return return_fielderror("ownvat")
if "foreignvat" not in payload:
return return_fielderror("foreignvat")
if "company" not in payload:
return return_fielderror("company")
if "town" not in payload:
return return_fielderror("town")
if "zip" not in payload:
return return_fielderror("zip")
if "street" not in payload:
return return_fielderror("street")
required_fields = ["key1", "key2", "ownvat", "foreignvat", "company", "town", "zip", "street"]
for field in required_fields:
if field not in payload:
return return_fielderror(field)

if "type" not in payload:
payload["type"] = (
Expand Down

0 comments on commit 76e9a88

Please sign in to comment.