Add support for get_client_name() and get_client_id() to engine #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mididings.engine.get_client_name() will return the unique name of the mididings sequencer engine, expecially useful for jack, which uses unique names for clients and thus will add "-01" (02, 03, ...) to the client_name set in the mididings.config(). mididings.engine.get_client_id() will return the client port number (ALSA) or client UUID (JACK), which is useful for ALSA, which instead allows clients with the same name. The result is an integer for ALSA, while for JACK is usually a (long) integer, but there's support for strings too (jack returns the UUID as a string, I actually don't know why).
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for mididings.engine.get_client_name() which returns the unique name of the mididings
sequencer engine (useful for unique jack names) and mididings.engine.get_client_id() which returns the client port number (ALSA) or client UUID (JACK) which in turn is useful for ALSA non-unique nature.
This is obviously not very useful for mididings only scripts, but for programs which use it as a module.
I have to make an apology: I know very little about programming, and, most important, I know almost nothing about c++. The code added looks "clean" and it works (at least on my machine), but I might have done things in a unorthodox way...