Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about IsStartupWizardCompleted to fix security issue #21

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

drinkataco
Copy link
Owner


name: Pull Request
about: Create a pull request to contribute to the Helm chart collection

Description

<IsStartupWizardCompleted /> would always be set to false after jellyfin started or restarted.

This was due to the system.xml configmap not including this value, so jellyfin would default it. However, this poses not only an annoyance but a security risk (as anybody could recreate through an admin account).

By adding a default value in the configmap we will have to make assumptions on the persisted state of jellyfin. Therefore, this configmap has been disabled by default and the README updated to reflect the default recommended configmap and this value and what to set it to.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Non-breaking change which adds functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have updated the chart version in Chart.yaml according to semantic versioning.
  • I have included any new or changed values in the values.yaml file and documented them in the README if applicable.
  • My changes are tested and proven to work.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.

@drinkataco drinkataco merged commit 13080ad into main Apr 6, 2024
2 checks passed
@drinkataco drinkataco deleted the fix/jellyfin_wizard branch April 6, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant