add codechecker workflow

.github/workflows/static_analysis.yml

@@ -0,0 +1,29 @@
+name: Static Analysis
+
+on:
+  push:
+    branches: [ "main" ]
+  pull_request:
+    branches: [ "main" ]
+
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    steps:
+    - name: checkout
+      uses: actions/checkout@v3
+
+    - name: generate compile commands
+      run: bazel run //:lib_compile_commands
+
+    - uses: whisperity/codechecker-analysis-action@v1
+      id: codechecker
+      with:
+        logfile: ${{ github.workspace }}/compile_commands.json
+
+    - uses: actions/upload-artifact@v2
+      with:
+        name: "CodeChecker Bug Reports"
+        path: ${{ steps.codechecker.outputs.result-html-dir }}

BUILD

@@ -9,6 +9,31 @@ refresh_compile_commands(
     }
 )
 
+refresh_compile_commands(
+    name = "example_compile_commands",
+    targets = {
+        "//examples/linux_rdbi_wdbi:all": "",
+    }
+)
+
+refresh_compile_commands(
+    name = "lib_compile_commands",
+    targets = {
+        "//:iso14229": "",
+    }
+)
+
+cc_library(
+    name = "iso14229",
+    srcs = [
+        "iso14229.c",
+        "iso14229.h",
+    ],
+    defines = [
+        "UDS_LINES",
+    ]
+)
+
 py_binary(
     name="amalgamate",
     srcs=["amalgamate.py"],
@@ -33,4 +58,15 @@ genrule(
     ],
     outs = ["iso14229.zip"],
     cmd = "mkdir iso14229 && cp -L $(SRCS) iso14229/ && zip -r $(OUTS) iso14229",
-)
+)
+
+# genrule(
+#     name = "cppcheck",
+#     srcs = [
+#         "iso14229.c",
+#         "iso14229.h",
+#         ".cppcheck/misra.json",
+#     ],
+#     outs = ["cppcheck.xml"],
+#     cmd = "cppcheck --xml --addon=.cppcheck/misra.json $(location iso14229.h) $(location iso14229.c) 2> $(OUTS)",
+# )

src/client.c

@@ -260,7 +260,7 @@ static UDSErr_t SendRequest(UDSClient_t *client) {
 
     if (client->_options_copy & UDS_SUPPRESS_POS_RESP) {
         // UDS-1:2013 8.2.2 Table 11
-        client->send_buf[1] |= 0x80;
+        client->send_buf[1] |= 0x80U;
     }
 
     changeState(client, kRequestStateSending);

src/tp/isotp_mock.c

@@ -176,6 +176,7 @@ UDSTp_t *ISOTPMockNew(const char *name, ISOTPMockArgs_t *args) {
         return NULL;
     }
     ISOTPMock_t *tp = malloc(sizeof(ISOTPMock_t));
+    memset(tp, 0, sizeof(ISOTPMock_t));
     if (name) {
         strncpy(tp->name, name, sizeof(tp->name));
     } else {

src/util.c

@@ -1,3 +1,5 @@
+#include "sys.h"
+#include "config.h"
 #include "util.h"
 #include "uds.h"