Merge pull request #53 from driftregion/fix_static_analysis

fix most static analysis defects in src/
driftregion · Feb 2, 2025 · 2695384 · 2695384
2 parents 36147cb + e11d6b7
commit 2695384
Show file tree

Hide file tree

Showing 14 changed files with 531 additions and 394 deletions.
diff --git a/.CodeChecker/skipfile.txt b/.CodeChecker/skipfile.txt
diff --git a/.gitignore b/.gitignore
@@ -27,3 +27,9 @@ compile_commands.json
 MODULE.bazel.lock
 iso14229.c
 iso14229.h
+html_report
+misra_reports
+**/*.ctu-info
+**/*.dump
+report.txt
+json_report.json
diff --git a/README.md b/README.md
@@ -94,7 +94,7 @@ see `enum UDSEvent` in [src/uds.h](src/uds.h)
 
 ```c
 typedef struct {
-    const enum UDSDiagnosticSessionType type; /**< requested session type */
+    const uint8_t type; /**< requested session type */
     uint16_t p2_ms;                           /**< optional return value: p2 timing override */
     uint32_t p2_star_ms;                      /**< optional return value: p2* timing override */
 } UDSDiagSessCtrlArgs_t;
@@ -114,7 +114,7 @@ typedef struct {
 
 ```c
 typedef struct {
-    const enum UDSECUResetType type; /**< reset type requested by client */
+    const uint8_t type; /**< reset type requested by client */
     uint8_t powerDownTime; /**< Optional response: notify client of time until shutdown (0-254) 255
                               indicates that a time is not available. */
 } UDSECUResetArgs_t;
@@ -189,8 +189,8 @@ typedef struct {
 
 ```c
 typedef struct {
-    enum UDSCommunicationControlType ctrlType; 
-    enum UDSCommunicationType commType;
+    uint8_t ctrlType; 
+    uint8_t commType;
 } UDSCommCtrlArgs_t;
 ```
 #### Supported Responses
@@ -393,6 +393,10 @@ bazel build //:release
 
 # Changelog
 
+## 0.9.0
+- breaking API changes:
+    - converted subfunction enums to #defines with standard-consistent naming
+
 ## 0.8.0
 - breaking API changes:
     - event enum consolidated `UDS_SRV_EVT_...` -> `UDS_EVT`